FIX cmakelists precompiled header is compiled only once.

Author: petrasvestartas

CMakeLists.txt

@@ -122,34 +122,38 @@ if (NOT SKBUILD)
   after editing C++ files.")
 endif()
 
-# Enhanced PCH configuration
-if (ENABLE_PRECOMPILED_HEADERS)
-    set(CMAKE_PCH_INSTANTIATE_TEMPLATES ON)
-    set(CMAKE_PCH_WARN_INVALID ON)
-endif() 
-
 # Find Python and nanobind
 find_package(Python 3.8
   REQUIRED COMPONENTS Interpreter Development.Module
   OPTIONAL_COMPONENTS Development.SABIModule)
 find_package(nanobind CONFIG REQUIRED)
 find_package(Threads REQUIRED)
 
+# Create a shared precompiled header library
+if (ENABLE_PRECOMPILED_HEADERS)
+    add_library(compas_pch INTERFACE)
+    target_precompile_headers(compas_pch INTERFACE src/compas.hpp)
+    target_include_directories(compas_pch INTERFACE
+        ${EIGEN_INCLUDE_DIR}
+        ${LIBIGL_INCLUDE_DIR}
+    )
+endif()
+
 # Function to add a nanobind module with include directories
 function(add_nanobind_module module_name source_file)
     nanobind_add_module(${module_name} STABLE_ABI NB_STATIC ${source_file})
 
     # Ensure external dependencies are downloaded first
     add_dependencies(${module_name} external_downloads)
 
-    # Add include directories
-    target_include_directories(${module_name} SYSTEM PRIVATE
-        ${EIGEN_INCLUDE_DIR}
-        ${LIBIGL_INCLUDE_DIR}
-    )
-
+    # Add include directories and link PCH if enabled
     if (ENABLE_PRECOMPILED_HEADERS)
-        target_precompile_headers(${module_name} PRIVATE src/compas.hpp)
+        target_link_libraries(${module_name} PRIVATE compas_pch)
+    else()
+        target_include_directories(${module_name} SYSTEM PRIVATE
+            ${EIGEN_INCLUDE_DIR}
+            ${LIBIGL_INCLUDE_DIR}
+        )
     endif()
 
     target_link_libraries(${module_name} PRIVATE Threads::Threads)

README.md

@@ -18,12 +18,9 @@ conda create -n igl compas_libigl
 A dev version of `compas_libigl` can be installed using a combination of conda and pip.
 
 ```bash
-conda create -n igl-dev python=3.9 git cmake">=3.14" boost eigen=3.3 pybind11 --yes
+conda create -n igl-dev python=3.9 --yes
 conda activate igl
-git clone --recursive https://github.com/BlockResearchGroup/compas_libigl.git
-cd compas_libigl
-rm -rf build
-pip install -e .
+pip install --no-build-isolation -ve .
 ```
 
 ## Libigl functions

src/boundaries.cpp

@@ -1,13 +1,23 @@
 #include "boundaries.hpp"
 
-void function(const Eigen::MatrixXd& V, const Eigen::MatrixXi& F) {}
+using namespace Eigen;
 
-NB_MODULE(curvature, m) {
+std::vector<std::vector<int>>
+trimesh_boundaries(
+    compas::RowMatrixXi F)
+{
+    std::vector<std::vector<int>> L;
 
+	igl::boundary_loop(F, L);
+
+    return L;
+}
+
+NB_MODULE(compas_libigl_boundaries, m) {
     m.def(
-        "function_name",
-        &function,
-        "Description.",
-        "V"_a,
-        "F"_a);
+        "trimesh_boundaries",
+        &trimesh_boundaries,
+        "Compute list of ordered boundary loops for a manifold mesh.",
+        "F"_a
+    );
 }