Nanobind #20

petrasvestartas · 2025-03-31T14:50:52Z

This is pull request to change pybind11 build system of C++ to Python binding to nanobind.

Following methods are wrapped:

Boundary loops
Curvature (gaussian - normals, principal, in-plane vectors)
Geodesic Distance
Ray/Mesh Intersections
Isolines
Mesh Mass Matrix
Mesh Parametrisations
Quad Mesh Planarisation
Remeshing from isolines

…_libigl # Conflicts: # CMakeLists.txt

…_libigl

added CGAL variable path to boost library removed MeshPattern temporarily rereferenced compas_plotters

added geodistance (heat and exact)

updated readme

tomvanmele · 2025-04-01T14:31:27Z

the isolines are wrong...

petrasvestartas · 2025-04-01T14:40:47Z

the isolines are wrong...

Is it related to building process or implementation?

Isolines method has been slightly changed in the recent libigl source code. Now it takes isovalues to retrieve output.
Also a third output is added for grouping. This helps to avoid x, y, z coordinate sorting.

tomvanmele · 2025-04-01T14:41:24Z

they are based on the OBJ coordinate direction instead of the orientation of the model

petrasvestartas · 2025-04-01T14:43:17Z

they are based on the OBJ coordinate direction instead of the orientation of the model

Is it about orientation:

petrasvestartas · 2025-04-02T21:45:39Z

Building libigl on all os works fine 🎉🥳🙌

Windows problem was this line in compas.h:
#define NOMINMAX

ToDo's before the final merge to align with compas_cgal workflow:

documentation examples: images and renaming: rename examples to example_name.py
add api for remeshing on isolines
add multiple iso remeshing split example from C++
check if cibuildwheels work correctly locally
bring test files from the methods docstrings to tests folder

petrasvestartas · 2025-04-03T23:39:19Z

@tomvanmele I would like to ask for a review.
The package build system is transformed to nanobind structure as in compas_cgal - one target per sub-module.

Multiple files were changed, the simplest way, would be to check the branch: https://github.com/petrasvestartas/compas_libigl/tree/nb

We see in this pull-request the whole history of commit. Should I leave it as is or should I create a new pull-request with the changes only?

Dependencies

C++ dependencies: eigen and libigl are handled via cmake.

Note: Third party dependencies like CGAL, embree, tetgen, Triangle, OpenGL pipeline libraries, are skipped since they are either used in other compas bindings and are only highly specific use cases of libigl that we dont need. None of the binded methods use that, as a result maintaining this package will be much easier.

Github Actions

Github actions are changed to the actions used in compas_cgal.

Tests

Minimal tests were added to the test folder for each binded method. Tests are helpful in github actions.

Docs

Documentation with tested examples:

Aufzeichnung.2025-04-04.014330.mp4

PYPI + Pending Publisher

Locally I tested the PYPI building process on windows and docker for linux:

For release to pypi we need the pending publisher:

tomvanmele · 2025-04-04T08:05:46Z

We see in this pull-request the whole history of commit. Should I leave it as is or should I create a new pull-request with the changes only?

perhaps a bit annoying, but i think it would be better...

tomvanmele · 2025-04-04T08:08:37Z

For release to pypi we need the pending publisher:

done

tomvanmele · 2025-04-04T05:03:04Z

docs/acknowledgements.rst

 ********************************************************************************

-Coming soon!
+COMPAS libigl


perhaps this subtitle is not needed?

tomvanmele · 2025-04-04T08:09:20Z

docs/examples/example_curvature_gaussian.py

+# Create two-color maps for negative and positive curvature
+cmap_negative = ColorMap.from_two_colors(Color.blue(), Color.yellow())
+cmap_positive = ColorMap.from_two_colors(Color.yellow(), Color.magenta())
+
+# Create vertex colors dictionary
+vertex_colors = {}
+for i, k in enumerate(gaussian_curvature):
+    if trimesh.is_vertex_on_boundary(i):
+        # Set boundary vertices to black
+        vertex_colors[i] = Color.black()
+    else:
+        if k < 0:
+            vertex_colors[i] = cmap_negative(k, minval=min_gaussian, maxval=0)
+        else:
+            vertex_colors[i] = cmap_positive(k, minval=0, maxval=max_gaussian)


not now, but we need to make things like this simpler

tomvanmele · 2025-04-04T08:11:28Z

docs/examples/example_curvature_gaussian.py

+normal_scale = -10
+for vertex in trimesh.vertices():
+    if not trimesh.is_vertex_on_boundary(vertex):
+        point = Point(*trimesh.vertex_coordinates(vertex))
+        normal = trimesh.vertex_normal(vertex)
+        k = gaussian_curvature[vertex]
+
+        scaled_normal = [n * normal_scale * k for n in normal]
+        end_point = Point(*(p + n for p, n in zip(point, scaled_normal)))


@Licini perhaps we can add a few special scene objects for making recurring visualisation patterns easier to execute

mesh vertex normals

mesh face normals

mesh/graph paths

...

tomvanmele · 2025-04-04T08:23:55Z

docs/examples/example_intersections.rst

@@ -1,10 +1,10 @@
 ********************************************************************************
-Ray/Mesh Intersections
+Mesh-ray intersections


it is the ray that intersects the mesh

tomvanmele · 2025-04-04T08:25:07Z

docs/examples/example_meshing_planes.py

+from compas.colors import ColorMap
+from compas.geometry import Rotation
+from compas.geometry import Scale
+import math


i can't believe this passes ruff linting and formatting

please turn on sorting in the project config

tomvanmele · 2025-04-04T08:27:11Z

docs/installation.rst

+Several examples use the COMPAS Viewer for visualisation.
+To install :mod:`compas_viewer` in the same environment

 .. code-block:: bash

-    git clone --recursive https://github.com/compas-dev/compas_libigl.git
+    conda activate libigl
+    pip install compas_viewer


tomvanmele · 2025-04-04T08:28:48Z

docs/tutorial.rst

+Curvature Analysis
+------------------

-    V, F = mesh.to_vertices_and_faces()
+* :func:`compas_libigl.trimesh_gaussian_curvature` - Compute Gaussian curvature at vertices
+* :func:`compas_libigl.trimesh_principal_curvature` - Compute principal curvatures and directions

-    source = trimesh.vertex_sample(size=1)[0]
-    distance = compas_libigl.trimesh_geodistance(
-        (V, F),
-        source,
-        method="heat",
-    )
+Geodesic Distances


not sure i would categorize this under analysis. for me this highlights why excessive structuring is not really helpful

tomvanmele · 2025-04-04T08:29:43Z

src/compas_libigl/geodistance.py

+
+    Parameters
+    ----------
+    M : tuple[:class:`list`, :class:`list`]


remove :class:

tomvanmele · 2025-04-04T08:30:22Z

src/compas_libigl/geodistance.py

+
+    Parameters
+    ----------
+    M : tuple[:class:`list`, :class:`list`]


should be tuple[list[list[float]], list[list[int]]]

tomvanmele · 2025-04-04T08:31:44Z

src/compas_libigl/planarize.py

+
+    Parameters
+    ----------
+    M : tuple[list[list[float]], list[list[int]]] | :class:`compas.datastructures.Mesh`


not sure if it is still true that the mesh unpacks into vertices and faces in current compas versions

petrasvestartas · 2025-04-04T21:19:37Z

@tomvanmele thank you for the corrections, I fixed them and added a new pull-request to avoid commit history.

#21

Also found the right command for ruff:
ruff check --select I --fix '/Users/petras/brg/2_code/forks/compas_libigl/docs/examples'

tomvanmele and others added 30 commits February 15, 2019 11:04

further simplified

caed4a0

add example 1

7ff3017

add

7021066

add

0dd9aa1

add

58ae77d

add

2eea877

add

17b1c9d

finish triangulation

1202111

add library

a93785f

Merge branch 'Ziqi'

b12608e

add readMe

ae31630

add image

b59668c

Update README.md

6d1cef1

update compas libigl

6b16776

Update README.md

9449bb4

Update README.md

b1275b9

add materials

3e3711a

using 3.7

913c34f

add MeshPattern

c2175d3

add

f36eb0b

Merge branch 'master' of https://github.com/BlockResearchGroup/compas…

c2b0846

…_libigl # Conflicts: # CMakeLists.txt

add mesh pattern

263c0ac

Merge branch 'master' of https://github.com/BlockResearchGroup/compas…

736a8a7

…_libigl

dunno

0c37f1d

development in specific igl environment

3045b55

added CGAL variable path to boost library removed MeshPattern temporarily rereferenced compas_plotters

adding modules into typical compas addon structure

c1a41b3

updated to latest igl and pybind

eee2386

added geodistance (heat and exact)

symbol problem with cgal

e3a5b44

boolean ops with cgal working

5e109f0

updated minimum requirement for cmake

3aaefb6

updated readme

petrasvestartas added 5 commits April 1, 2025 15:50

ADD isolines.

7169efb

ADD isolines.

7458a99

ADD massmatrix.

f290e96

ADD parametrisation.

2dd0f32

DOCS

ff0c732

petrasvestartas added 7 commits April 1, 2025 18:40

ADD iso remeshing.

0bc4e57

FIX windows temporary fix for geodesics.

14a48c6

LINT

31349e6

FIX Windows nominmax and split pch into multiple headers.

dc89e32

Remove build artifacts and external dependencies

722d3a5

Merge branch 'main' into nb

77479f2

TEMP

cb447a2

petrasvestartas added 5 commits April 3, 2025 01:39

FIX multi iso-values remeshing.

c2f4449

DOC-TEST files.

1a197ac

ADD cpp header declarations.

8d82e31

CLEANUP

ec11fef

DOCS-BUILD images and requirements.

91575b7

petrasvestartas requested a review from tomvanmele April 3, 2025 23:52

CLEANUP

b643e57

tomvanmele reviewed Apr 4, 2025

View reviewed changes

petrasvestartas closed this Apr 4, 2025

Nanobind #20

Nanobind #20

Uh oh!

Conversation

petrasvestartas commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomvanmele commented Apr 1, 2025

Uh oh!

petrasvestartas commented Apr 1, 2025

Uh oh!

tomvanmele commented Apr 1, 2025

Uh oh!

petrasvestartas commented Apr 1, 2025

Uh oh!

petrasvestartas commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petrasvestartas commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependencies

Github Actions

Tests

Docs

PYPI + Pending Publisher

Uh oh!

tomvanmele commented Apr 4, 2025

Uh oh!

tomvanmele commented Apr 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petrasvestartas commented Apr 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

petrasvestartas commented Mar 31, 2025 •

edited

Loading

petrasvestartas commented Apr 2, 2025 •

edited

Loading

petrasvestartas commented Apr 3, 2025 •

edited

Loading