-
Notifications
You must be signed in to change notification settings - Fork 8
Pattern mapping #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern mapping #23
Conversation
docs/examples/example_mapping.py
Outdated
| p_uv = igl.trimesh_simple((pv, pf)) | ||
| mesh_mapped = igl.map_mesh(v, f, uv, pv, pf, p_uv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
igl.trimesh_simple takes mesh info as a tuple of vertices and faces, whereas igl.map_mesh accepts vertices and faces individually. would perhaps be better to be consistent.
igl.map_mesh((v, f), (pv, pf), uv, p_uv)?igl.map_mesh((v, f, uv), (pv, pf, p_uv))?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, igl.trimesh_simple doesn't really say what it does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and perhaps it is more user-friendly to eliminate the in between step:
igl.map_mesh_simple((v, f), (pv, pf))igl.map_mesh_lscm((v, f), (pv, pf))- ...
|
Added a few examples for boundaries and exploration of Tessagon patterns: |
tomvanmele
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few small things but otherwise LGTM
requirements-dev.txt
Outdated
| setuptools | ||
| cibuildwheel==2.23.1 | ||
| cibuildwheel==2.23.1 | ||
| tessagon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed here
src/compas_libigl/__init__.py
Outdated
| "trimesh_massmatrix", | ||
| "trimesh_harmonic", | ||
| "trimesh_lscm", | ||
| "trimesh_map_aabb", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps not to be changed now, but i still find these names not very intuitive. something like this might be better:
trimesh_harmonic_mappingtrimesh_lsc_mappingtriemsh_aabb_mapping



Mapping 2D mesh to a 3D mesh.
How it works: