fix seg fault

Author: tomvanmele

CHANGELOG.md

@@ -43,6 +43,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 * Fixed bug in propagation of linear and angular deflection between discretisation functions `OCCBrep.to_viewmesh` and `OCCBrep.to_tesselation`.
+* Fixed potential causes of segmentation fault (`OCCBrepVertex.is_same`, `OCCBrepEdge.is_same`, `OCCBrepLoop.is_same`, `OCCBrepFace.is_same`).
 
 ### Removed
 

src/compas_occ/brep/brepedge.py

@@ -122,6 +122,8 @@ def is_same(self, other: "OCCBrepEdge") -> bool:
             ``True`` if the edges are the same, ``False`` otherwise.
 
         """
+        if not isinstance(other, OCCBrepEdge):
+            return False
         return self.occ_edge.IsSame(other.occ_edge)
 
     def is_equal(self, other: "OCCBrepEdge") -> bool:

src/compas_occ/brep/brepface.py

@@ -183,6 +183,8 @@ def is_same(self, other: "OCCBrepFace") -> bool:
             ``True`` if the faces are the same, ``False`` otherwise.
 
         """
+        if not isinstance(other, OCCBrepFace):
+            return False
         return self.occ_face.IsSame(other.occ_face)
 
     def is_equal(self, other: "OCCBrepFace") -> bool:

src/compas_occ/brep/breploop.py

@@ -81,6 +81,8 @@ def is_same(self, other: "OCCBrepLoop") -> bool:
             ``True`` if the loops are the same, ``False`` otherwise.
 
         """
+        if not isinstance(other, OCCBrepLoop):
+            return False
         return self.occ_wire.IsSame(other.occ_wire)
 
     def is_equal(self, other: "OCCBrepLoop") -> bool:
@@ -206,7 +208,7 @@ def from_polygon(cls, polygon: Polygon) -> "OCCBrepLoop":
 
         """
         edges = []
-        for a, b in pairwise(polygon.points):
+        for a, b in pairwise(polygon.points + polygon.points[:1]):
             edge = OCCBrepEdge.from_point_point(a, b)
             edges.append(edge)
         return cls(wire_from_edges(edges))

src/compas_occ/brep/brepvertex.py

@@ -55,6 +55,8 @@ def is_same(self, other: "OCCBrepVertex") -> bool:
             ``True`` if the vertices are the same, ``False`` otherwise.
 
         """
+        if not isinstance(other, OCCBrepVertex):
+            return False
         return self.occ_vertex.IsSame(other.occ_vertex)
 
     def is_equal(self, other: "OCCBrepVertex") -> bool: