Skip to content

Commit 52bc7e1

Browse files
committed
lint, format, ellipsis
1 parent 3ec3c6f commit 52bc7e1

File tree

17 files changed

+255
-367
lines changed

17 files changed

+255
-367
lines changed

src/compas_occ/brep/brep.py

Lines changed: 37 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,29 @@
1-
from typing import List, Tuple, Union, Optional
1+
from typing import List
2+
from typing import Optional
3+
from typing import Tuple
4+
from typing import Union
25

3-
import compas.geometry
46
import compas.datastructures
5-
6-
from compas.geometry import Vector
7+
import compas.geometry
8+
from compas.datastructures import Mesh
9+
from compas.geometry import Brep
710
from compas.geometry import Frame
8-
from compas.geometry import Translation
11+
from compas.geometry import Plane
912
from compas.geometry import Point
10-
from compas.geometry import Polyline
1113
from compas.geometry import Polygon
12-
from compas.geometry import Plane
13-
from compas.datastructures import Mesh
14-
from compas.geometry import Brep
15-
14+
from compas.geometry import Polyline
15+
from compas.geometry import Translation
16+
from compas.geometry import Vector
1617
from OCC.Core import BOPAlgo
17-
from OCC.Core import BRepAlgoAPI
1818
from OCC.Core import BRep
19+
from OCC.Core import BRepAlgoAPI
1920
from OCC.Core import BRepBuilderAPI
2021
from OCC.Core import BRepCheck
2122
from OCC.Core import BRepExtrema
2223
from OCC.Core import BRepFilletAPI
2324
from OCC.Core import BRepGProp
2425
from OCC.Core import BRepMesh
2526
from OCC.Core import BRepPrimAPI
26-
from OCC.Core import gp
2727
from OCC.Core import GProp
2828
from OCC.Core import IFSelect
2929
from OCC.Core import IGESControl
@@ -36,25 +36,24 @@
3636
from OCC.Core import TopLoc
3737
from OCC.Core import TopoDS
3838
from OCC.Core import TopTools
39-
39+
from OCC.Core import gp
4040
from OCC.Extend import DataExchange
4141

42-
from compas_occ.conversions import triangle_to_face
43-
from compas_occ.conversions import quad_to_face
44-
from compas_occ.conversions import ngon_to_face
4542
from compas_occ.conversions import compas_transformation_to_trsf
43+
from compas_occ.conversions import frame_to_occ_ax2
44+
from compas_occ.conversions import location_to_compas
45+
from compas_occ.conversions import ngon_to_face
4646
from compas_occ.conversions import point_to_compas
47+
from compas_occ.conversions import quad_to_face
48+
from compas_occ.conversions import triangle_to_face
4749
from compas_occ.conversions import vector_to_occ
48-
from compas_occ.conversions import location_to_compas
49-
from compas_occ.conversions import frame_to_occ_ax2
5050
from compas_occ.geometry import OCCNurbsSurface
5151

52-
from .errors import BrepFilletError
53-
54-
from .brepvertex import OCCBrepVertex
5552
from .brepedge import OCCBrepEdge
56-
from .breploop import OCCBrepLoop
5753
from .brepface import OCCBrepFace
54+
from .breploop import OCCBrepLoop
55+
from .brepvertex import OCCBrepVertex
56+
from .errors import BrepFilletError
5857

5958

6059
class OCCBrep(Brep):
@@ -563,9 +562,7 @@ def from_box(cls, box: compas.geometry.Box) -> "OCCBrep":
563562
zaxis = box.frame.zaxis.scaled(-0.5 * box.zsize)
564563
frame = box.frame.transformed(Translation.from_vector(xaxis + yaxis + zaxis))
565564
ax2 = frame_to_occ_ax2(frame) # type: ignore
566-
shape = BRepPrimAPI.BRepPrimAPI_MakeBox(
567-
ax2, box.xsize, box.ysize, box.zsize
568-
).Shape()
565+
shape = BRepPrimAPI.BRepPrimAPI_MakeBox(ax2, box.xsize, box.ysize, box.zsize).Shape()
569566
return cls.from_native(shape)
570567

571568
@classmethod
@@ -582,9 +579,7 @@ def from_sphere(cls, sphere: compas.geometry.Sphere) -> "OCCBrep":
582579
:class:`~compas_occ.brep.OCCBrep`
583580
584581
"""
585-
shape = BRepPrimAPI.BRepPrimAPI_MakeSphere(
586-
gp.gp_Pnt(*sphere.frame.point), sphere.radius
587-
).Shape()
582+
shape = BRepPrimAPI.BRepPrimAPI_MakeSphere(gp.gp_Pnt(*sphere.frame.point), sphere.radius).Shape()
588583
return cls.from_native(shape)
589584

590585
@classmethod
@@ -642,9 +637,7 @@ def from_torus(cls, torus: compas.geometry.Torus) -> "OCCBrep":
642637
raise NotImplementedError
643638

644639
@classmethod
645-
def from_mesh(
646-
cls, mesh: compas.datastructures.Mesh, solid: bool = True
647-
) -> "OCCBrep":
640+
def from_mesh(cls, mesh: compas.datastructures.Mesh, solid: bool = True) -> "OCCBrep":
648641
"""
649642
Construct a BRep from a COMPAS mesh.
650643
@@ -909,9 +902,7 @@ def from_boolean_union(cls, A: "OCCBrep", B: "OCCBrep") -> "OCCBrep":
909902
# Converters
910903
# ==============================================================================
911904

912-
def to_tesselation(
913-
self, linear_deflection: float = 1
914-
) -> Tuple[Mesh, List[Polyline]]:
905+
def to_tesselation(self, linear_deflection: float = 1) -> Tuple[Mesh, List[Polyline]]:
915906
"""
916907
Create a tesselation of the shape for visualisation.
917908
@@ -955,9 +946,7 @@ def to_tesselation(
955946
if any(edge.is_same(e) for e in seen):
956947
continue
957948
seen.append(edge)
958-
pot = bt.PolygonOnTriangulation(
959-
edge.occ_edge, triangulation, location
960-
)
949+
pot = bt.PolygonOnTriangulation(edge.occ_edge, triangulation, location)
961950
if pot is None:
962951
continue
963952
points = []
@@ -971,9 +960,7 @@ def to_tesselation(
971960
if any(edge.is_same(e) for e in seen):
972961
continue
973962
if edge.is_line:
974-
lines.append(
975-
Polyline([edge.vertices[0].point, edge.vertices[-1].point])
976-
)
963+
lines.append(Polyline([edge.vertices[0].point, edge.vertices[-1].point]))
977964
elif edge.is_circle:
978965
lines.append(edge.curve.to_polyline())
979966
elif edge.is_ellipse:
@@ -1042,9 +1029,7 @@ def vertex_neighbors(self, vertex: OCCBrepVertex) -> List[OCCBrepVertex]:
10421029
10431030
"""
10441031
map = TopTools.TopTools_IndexedDataMapOfShapeListOfShape()
1045-
TopExp.topexp_MapShapesAndUniqueAncestors(
1046-
self.occ_shape, TopAbs.TopAbs_VERTEX, TopAbs.TopAbs_EDGE, map
1047-
)
1032+
TopExp.topexp_MapShapesAndUniqueAncestors(self.occ_shape, TopAbs.TopAbs_VERTEX, TopAbs.TopAbs_EDGE, map)
10481033
results = map.FindFromKey(vertex.occ_vertex)
10491034
iterator = TopTools.TopTools_ListIteratorOfListOfShape(results) # type: ignore
10501035
vertices = []
@@ -1072,9 +1057,7 @@ def vertex_edges(self, vertex: OCCBrepVertex) -> List[OCCBrepEdge]:
10721057
10731058
"""
10741059
map = TopTools.TopTools_IndexedDataMapOfShapeListOfShape()
1075-
TopExp.topexp_MapShapesAndUniqueAncestors(
1076-
self.occ_shape, TopAbs.TopAbs_VERTEX, TopAbs.TopAbs_EDGE, map
1077-
)
1060+
TopExp.topexp_MapShapesAndUniqueAncestors(self.occ_shape, TopAbs.TopAbs_VERTEX, TopAbs.TopAbs_EDGE, map)
10781061
results = map.FindFromKey(vertex.occ_vertex)
10791062
iterator = TopTools.TopTools_ListIteratorOfListOfShape(results) # type: ignore
10801063
edges = []
@@ -1098,9 +1081,7 @@ def vertex_faces(self, vertex: OCCBrepVertex) -> List[OCCBrepFace]:
10981081
10991082
"""
11001083
map = TopTools.TopTools_IndexedDataMapOfShapeListOfShape()
1101-
TopExp.topexp_MapShapesAndUniqueAncestors(
1102-
self.occ_shape, TopAbs.TopAbs_VERTEX, TopAbs.TopAbs_FACE, map
1103-
)
1084+
TopExp.topexp_MapShapesAndUniqueAncestors(self.occ_shape, TopAbs.TopAbs_VERTEX, TopAbs.TopAbs_FACE, map)
11041085
results = map.FindFromKey(vertex.occ_vertex)
11051086
iterator = TopTools.TopTools_ListIteratorOfListOfShape(results) # type: ignore
11061087
faces = []
@@ -1124,9 +1105,7 @@ def edge_faces(self, edge: OCCBrepEdge) -> List[OCCBrepFace]:
11241105
11251106
"""
11261107
map = TopTools.TopTools_IndexedDataMapOfShapeListOfShape()
1127-
TopExp.topexp_MapShapesAndUniqueAncestors(
1128-
self.occ_shape, TopAbs.TopAbs_EDGE, TopAbs.TopAbs_FACE, map
1129-
)
1108+
TopExp.topexp_MapShapesAndUniqueAncestors(self.occ_shape, TopAbs.TopAbs_EDGE, TopAbs.TopAbs_FACE, map)
11301109
results = map.FindFromKey(edge.occ_edge)
11311110
iterator = TopTools.TopTools_ListIteratorOfListOfShape(results) # type: ignore
11321111
faces = []
@@ -1152,9 +1131,7 @@ def edge_loops(self, edge: OCCBrepEdge) -> List[OCCBrepLoop]:
11521131
"""
11531132

11541133
map = TopTools.TopTools_IndexedDataMapOfShapeListOfShape()
1155-
TopExp.topexp_MapShapesAndUniqueAncestors(
1156-
self.occ_shape, TopAbs.TopAbs_EDGE, TopAbs.TopAbs_WIRE, map
1157-
)
1134+
TopExp.topexp_MapShapesAndUniqueAncestors(self.occ_shape, TopAbs.TopAbs_EDGE, TopAbs.TopAbs_WIRE, map)
11581135
results = map.FindFromKey(edge.occ_edge)
11591136
iterator = TopTools.TopTools_ListIteratorOfListOfShape(results) # type: ignore
11601137
loops = []
@@ -1332,9 +1309,7 @@ def transformed(self, matrix: compas.geometry.Transformation) -> "OCCBrep":
13321309
shape = builder.ModifiedShape(self.occ_shape)
13331310
return OCCBrep.from_shape(shape)
13341311

1335-
def contours(
1336-
self, planes: List[compas.geometry.Plane]
1337-
) -> List[List[compas.geometry.Polyline]]:
1312+
def contours(self, planes: List[compas.geometry.Plane]) -> List[List[compas.geometry.Polyline]]:
13381313
"""
13391314
Generate contour lines by slicing the BRep shape with a series of planes.
13401315
@@ -1438,10 +1413,11 @@ def trim(self, plane: compas.geometry.Plane) -> None:
14381413
None
14391414
14401415
"""
1441-
from compas_occ.occ import split_shapes
1442-
from compas_occ.occ import compute_shape_centreofmass
14431416
from compas.geometry import is_point_behind_plane
14441417

1418+
from compas_occ.occ import compute_shape_centreofmass
1419+
from compas_occ.occ import split_shapes
1420+
14451421
if isinstance(plane, Frame):
14461422
plane = Plane.from_frame(plane)
14471423

@@ -1540,9 +1516,7 @@ def fillet(
15401516
else:
15411517
raise BrepFilletError("Fillet operation could not be completed.")
15421518

1543-
def filleted(
1544-
self, radius: float, exclude: Optional[List[OCCBrepEdge]] = None
1545-
) -> "OCCBrep":
1519+
def filleted(self, radius: float, exclude: Optional[List[OCCBrepEdge]] = None) -> "OCCBrep":
15461520
"""Construct a copy of a Brep with filleted edges.
15471521
15481522
Parameters

src/compas_occ/brep/brepedge.py

Lines changed: 28 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,35 @@
11
from typing import List
2-
from typing import Tuple
32
from typing import Optional
3+
from typing import Tuple
44

5+
from compas.geometry import Bezier
6+
from compas.geometry import BrepEdge
7+
from compas.geometry import Circle
8+
from compas.geometry import Ellipse
9+
from compas.geometry import Hyperbola
10+
from compas.geometry import Line
11+
from compas.geometry import NurbsCurve
12+
from compas.geometry import Parabola
13+
from compas.geometry import Point
514
from OCC.Core import BRepAdaptor
6-
from OCC.Core import BRepBuilderAPI
715
from OCC.Core import BRepAlgo
16+
from OCC.Core import BRepBuilderAPI
817
from OCC.Core import BRepGProp
918
from OCC.Core import GProp
1019
from OCC.Core import TopAbs
11-
from OCC.Core import TopoDS
1220
from OCC.Core import TopExp
13-
14-
from compas.geometry import Point
15-
from compas.geometry import Line
16-
from compas.geometry import Circle
17-
from compas.geometry import Ellipse
18-
from compas.geometry import Hyperbola
19-
from compas.geometry import Parabola
20-
from compas.geometry import Bezier
21-
from compas.geometry import NurbsCurve
22-
from compas.geometry import BrepEdge
21+
from OCC.Core import TopoDS
2322

2423
from compas_occ.brep import OCCBrepVertex
25-
from compas_occ.conversions import line_to_occ
26-
from compas_occ.conversions import point_to_occ
27-
from compas_occ.conversions import circle_to_occ
24+
from compas_occ.conversions import bezier_to_compas
25+
from compas_occ.conversions import bspline_to_compas
2826
from compas_occ.conversions import circle_to_compas
27+
from compas_occ.conversions import circle_to_occ
2928
from compas_occ.conversions import ellipse_to_compas
3029
from compas_occ.conversions import hyperbola_to_compas
30+
from compas_occ.conversions import line_to_occ
3131
from compas_occ.conversions import parabola_to_compas
32-
from compas_occ.conversions import bezier_to_compas
33-
from compas_occ.conversions import bspline_to_compas
32+
from compas_occ.conversions import point_to_occ
3433
from compas_occ.geometry import OCCCurve
3534
from compas_occ.geometry import OCCCurve2d
3635
from compas_occ.geometry import OCCSurface
@@ -345,9 +344,7 @@ def from_point_point(cls, a: Point, b: Point) -> "OCCBrepEdge":
345344
The constructed edge.
346345
347346
"""
348-
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(
349-
point_to_occ(a), point_to_occ(b)
350-
)
347+
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(point_to_occ(a), point_to_occ(b))
351348
return cls(builder.Edge())
352349

353350
@classmethod
@@ -423,9 +420,7 @@ def from_circle(
423420
424421
"""
425422
if params:
426-
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(
427-
circle_to_occ(circle), *params
428-
)
423+
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(circle_to_occ(circle), *params)
429424
elif points:
430425
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(
431426
circle_to_occ(circle),
@@ -513,9 +508,7 @@ def from_curve(
513508
curve2d.occ_curve, surface.occ_surface, p1, p2, *params
514509
)
515510
else:
516-
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(
517-
curve2d.occ_curve, surface.occ_surface, p1, p2
518-
)
511+
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(curve2d.occ_curve, surface.occ_surface, p1, p2)
519512
elif vertices:
520513
v1 = vertices[0].occ_vertex
521514
v2 = vertices[1].occ_vertex
@@ -524,18 +517,12 @@ def from_curve(
524517
curve2d.occ_curve, surface.occ_surface, v1, v2, *params
525518
)
526519
else:
527-
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(
528-
curve2d.occ_curve, surface.occ_surface, v1, v2
529-
)
520+
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(curve2d.occ_curve, surface.occ_surface, v1, v2)
530521
else:
531522
if params:
532-
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(
533-
curve2d.occ_curve, surface.occ_surface, *params
534-
)
523+
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(curve2d.occ_curve, surface.occ_surface, *params)
535524
else:
536-
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(
537-
curve2d.occ_curve, surface.occ_surface
538-
)
525+
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(curve2d.occ_curve, surface.occ_surface)
539526
else:
540527
if not curve:
541528
raise ValueError("No curve was provided.")
@@ -544,29 +531,19 @@ def from_curve(
544531
p1 = point_to_occ(points[0])
545532
p2 = point_to_occ(points[1])
546533
if params:
547-
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(
548-
curve.occ_curve, p1, p2, *params
549-
)
534+
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(curve.occ_curve, p1, p2, *params)
550535
else:
551-
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(
552-
curve.occ_curve, p1, p2
553-
)
536+
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(curve.occ_curve, p1, p2)
554537
elif vertices:
555538
v1 = vertices[0].occ_vertex
556539
v2 = vertices[1].occ_vertex
557540
if params:
558-
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(
559-
curve.occ_curve, v1, v2, *params
560-
)
541+
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(curve.occ_curve, v1, v2, *params)
561542
else:
562-
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(
563-
curve.occ_curve, v1, v2
564-
)
543+
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(curve.occ_curve, v1, v2)
565544
else:
566545
if params:
567-
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(
568-
curve.occ_curve, *params
569-
)
546+
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(curve.occ_curve, *params)
570547
else:
571548
builder = BRepBuilderAPI.BRepBuilderAPI_MakeEdge(curve.occ_curve)
572549

0 commit comments

Comments
 (0)