SHAPEOP_SRC_DIR files missing

[jf---]

oops, seems related to a PR in progress

---

hi @petrasvestartas , this is exciting, shapeop is a bit of trip down memory lane.

It seems to me that the .cpp / .h files are missing in the current state of the repo?
For instance I couldn't trace the following C++ files:

# ShapeOp library with core and custom components
add_library(shapeop STATIC
  # Core ShapeOp files
  ${SHAPEOP_SRC_DIR}/Constraint.cpp
  ${SHAPEOP_SRC_DIR}/Force.cpp
  ${SHAPEOP_SRC_DIR}/LSSolver.cpp
  ${SHAPEOP_SRC_DIR}/Solver.cpp
  # Custom constraints/forces
  ${SHAPEOP_SRC_DIR}/custom_constraints/NormalForce.cpp
)

[petrasvestartas]

Hi,

Please try this pull request:
#2

I have deleted the files on purpose in the main branch to refactor Python API and make review possible. It would be great if you could try that development branch to see if it works.

Currently I am making a few simpler mesh based Python API.

[tomvanmele]

@petrasvestartas i just approved and merged it. let's work on the API in a next PR...

[jf---]

a little closer; I'm on macOS, curious

(bbc) ➜  compas_shapeop git:(main) ✗ pip install --no-build-isolation -ve .
Using pip 24.2 from /Users/jelle/mambaforge/envs/bbc/lib/python3.10/site-packages/pip (python 3.10)
Obtaining file:///Users/jelle/Code/CADCAM/compas_shapeop
  Running command Checking if build backend supports build_editable
  Checking if build backend supports build_editable ... done
  Running command Preparing editable metadata (pyproject.toml)
  *** scikit-build-core 0.11.2 using CMake 3.30.5 (metadata_editable)
  Preparing editable metadata (pyproject.toml) ... done
Building wheels for collected packages: compas_shapeop
  Running command Building editable for compas_shapeop (pyproject.toml)
  *** scikit-build-core 0.11.2 using CMake 3.30.5 (editable)
  *** Configuring CMake...
  loading initial cache file build/cp310-cp310-macosx_15_0_arm64/CMakeInit.txt
  -- OpenMP found - enabling parallel processing
  -- ============= Build Configuration =============
  -- Build Type: Release
  -- C++ Standard: C++20
  -- Optimization: OFF (O0 if ON, O3 if OFF)
  -- Precompiled Headers: ON
  -- =============================================
  -- Configuring done (0.1s)
  -- Generating done (0.0s)
  -- Build files have been written to: /Users/jelle/Code/CADCAM/compas_shapeop/build/cp310-cp310-macosx_15_0_arm64
  *** Building project with Unix Makefiles...
  [  4%] Building CXX object CMakeFiles/shapeop.dir/src/shapeop/Constraint.cpp.o
  clang++: error: unknown argument: '-Xclang -fopenmp'
  make[2]: *** [CMakeFiles/shapeop.dir/src/shapeop/Constraint.cpp.o] Error 1
  make[1]: *** [CMakeFiles/shapeop.dir/all] Error 2
  make: *** [all] Error 2

  *** CMake build failed
  error: subprocess-exited-with-error
  
  × Building editable for compas_shapeop (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> See above for output.
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  full command: /Users/jelle/mambaforge/envs/bbc/bin/python3.10 /Users/jelle/mambaforge/envs/bbc/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py build_editable /var/folders/3m/xdqrhcm156l0qfgc_mzk_2v00000gn/T/tmpa_p7avof
  cwd: /Users/jelle/Code/CADCAM/compas_shapeop
  Building editable for compas_shapeop (pyproject.toml) ... error
  ERROR: Failed building editable for compas_shapeop
Failed to build compas_shapeop

a bit more verbose:

  clang++: error: unknown argument: '-Xclang -fopenmp'
  [12/21] Building CXX object CMakeFiles/nanobind-static.dir/Users/jelle/mambaforge/envs/bbc/lib/python3.10/site-packages/nanobind/src/nb_static_property.cpp.o
  FAILED: CMakeFiles/nanobind-static.dir/Users/jelle/mambaforge/envs/bbc/lib/python3.10/site-packages/nanobind/src/nb_static_property.cpp.o
  /Library/Developer/CommandLineTools/usr/bin/clang++ -DNB_COMPACT_ASSERTIONS -DSHAPEOP_OPENMP -I/Users/jelle/mambaforge/envs/bbc/lib/python3.10/site-packages/nanobind/ext/robin_map/include -I/Users/jelle/mambaforge/envs/bbc/include/python3.10 -I/Users/jelle/mambaforge/envs/bbc/lib/python3.10/site-packages/nanobind/include -O3 -DNDEBUG -std=gnu++20 -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX15.4.sdk -mmacosx-version-min=15.3 -fPIC -fvisibility=hidden -O3 "-Xclang -fopenmp" -fno-strict-aliasing -MD -MT CMakeFiles/nanobind-static.dir/Users/jelle/mambaforge/envs/bbc/lib/python3.10/site-packages/nanobind/src/nb_static_property.cpp.o -MF CMakeFiles/nanobind-static.dir/Users/jelle/mambaforge/envs/bbc/lib/python3.10/site-packages/nanobind/src/nb_static_property.cpp.o.d -o CMakeFiles/nanobind-static.dir/Users/jelle/mambaforge/envs/bbc/lib/python3.10/site-packages/nanobind/src/nb_static_property.cpp.o -c /Users/jelle/mambaforge/envs/bbc/lib/python3.10/site-packages/nanobind/src/nb_static_property.cpp
  clang++: error: unknown argument: '-Xclang -fopenmp'
  ninja: build stopped: subcommand failed.

  *** CMake build failed
  error: subprocess-exited-with-error
  
  × Building editable for compas_shapeop (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

since we share the same platform, curious if you managed to compile @tomvanmele ?

again, really cool work @petrasvestartas ; on a roll 🦾

[petrasvestartas]

@jf---

Thank you very much for testing this package.
I have pushed a fix to current repository for the CMakelists.

Before, i tested this on ubuntu and windows.

Now it should work for mac too:

Please let me know if the latest fix works on your machine.

[jf---]

hi @petrasvestartas happy to contribute;

great, I could reproduce the macOS build and almost all the examples with 2 exceptions due to missing files:

• data/m0.obj
• data/hex_mesh.json

(base) ➜  examples git:(main) py face_normal_force.py               
Traceback (most recent call last):
  File "/Users/jelle/Code/CADCAM/compas_shapeop/examples/face_normal_force.py", line 10, in <module>
    mesh = Mesh.from_obj("data/m0.obj")
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jelle/mambaforge/lib/python3.12/site-packages/compas/datastructures/mesh/mesh.py", line 296, in from_obj
    obj.read()
  File "/Users/jelle/mambaforge/lib/python3.12/site-packages/compas/files/obj.py", line 109, in read
    self._reader.open()
  File "/Users/jelle/mambaforge/lib/python3.12/site-packages/compas/files/obj.py", line 239, in open
    with _iotools.open_file(self.filepath, "r") as f:
  File "/Users/jelle/mambaforge/lib/python3.12/contextlib.py", line 137, in __enter__
    return next(self.gen)
           ^^^^^^^^^^^^^^
  File "/Users/jelle/mambaforge/lib/python3.12/site-packages/compas/_iotools.py", line 52, in open_file
    file = open(file, mode=mode)
           ^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'data/m0.obj'
(base) ➜  examples git:(main) py mesh_regularization.py 
Traceback (most recent call last):
  File "/Users/jelle/Code/CADCAM/compas_shapeop/examples/mesh_regularization.py", line 10, in <module>
    mesh = compas.json_load("data/hex_mesh.json")
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jelle/mambaforge/lib/python3.12/site-packages/compas/data/json.py", line 206, in json_load
    with _iotools.open_file(fp, "r") as f:
  File "/Users/jelle/mambaforge/lib/python3.12/contextlib.py", line 137, in __enter__
    return next(self.gen)
           ^^^^^^^^^^^^^^
  File "/Users/jelle/mambaforge/lib/python3.12/site-packages/compas/_iotools.py", line 52, in open_file
    file = open(file, mode=mode)
           ^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'data/hex_mesh.json'

[petrasvestartas]

Thanks :)

[jf---]

due to missing files:

false accusations; all files ran perfectly ( py examples/face_normal_force.py vs py face_normal_force.py )