Skip to content

Component methods that use context fail (antd) #3

@Driphter

Description

@Driphter

I'm running into an issue with using omify on Ant Design's Menu and Sider components. When I put a Menu in a Sider and click the collapse icon I get the following exception:

Uncaught TypeError: Cannot read property 'siderCollapsed' of undefined
    at Menu.componentWillReceiveProps (antd.inc.js:27049)
    at Menu.<anonymous> (antd.cljs:49)
    at react-dom.inc.js:5117
    at measureLifeCyclePerf (react-dom.inc.js:4581)
    at ReactCompositeComponentWrapper.updateComponent (react-dom.inc.js:5116)
    at ReactCompositeComponentWrapper.receiveComponent (react-dom.inc.js:5053)
    at Object.receiveComponent (react-dom.inc.js:11677)
    at Object.updateChildren (react-dom.inc.js:4384)
    at ReactDOMComponent._reconcilerUpdateChildren (react-dom.inc.js:10455)
    at ReactDOMComponent._updateChildren (react-dom.inc.js:10559)
    at ReactDOMComponent.updateChildren (react-dom.inc.js:10546)
    at ReactDOMComponent._updateDOMChildren (react-dom.inc.js:6455)
    at ReactDOMComponent.updateComponent (react-dom.inc.js:6273)
    at ReactDOMComponent.receiveComponent (react-dom.inc.js:6235)
    at Object.receiveComponent (react-dom.inc.js:11677)
    at Object.updateChildren (react-dom.inc.js:4384)
    at ReactDOMComponent._reconcilerUpdateChildren (react-dom.inc.js:10455)
    at ReactDOMComponent._updateChildren (react-dom.inc.js:10559)
    at ReactDOMComponent.updateChildren (react-dom.inc.js:10546)
    at ReactDOMComponent._updateDOMChildren (react-dom.inc.js:6455)
    at ReactDOMComponent.updateComponent (react-dom.inc.js:6273)
    at ReactDOMComponent.receiveComponent (react-dom.inc.js:6235)
    at Object.receiveComponent (react-dom.inc.js:11677)
    at ReactCompositeComponentWrapper._updateRenderedComponent (react-dom.inc.js:5260)
    at ReactCompositeComponentWrapper._performComponentUpdate (react-dom.inc.js:5230)
    at ReactCompositeComponentWrapper.updateComponent (react-dom.inc.js:5151)
    at ReactCompositeComponentWrapper.performUpdateIfNecessary (react-dom.inc.js:5067)
    at Object.performUpdateIfNecessary (react-dom.inc.js:11709)
    at runBatchedUpdates (react-dom.inc.js:12997)
    at ReactReconcileTransaction.perform (react-dom.inc.js:14816)
    at ReactUpdatesFlushTransaction.perform (react-dom.inc.js:14816)
    at ReactUpdatesFlushTransaction.perform (react-dom.inc.js:12936)
    at Object.flushBatchedUpdates (react-dom.inc.js:13019)
    at ReactDefaultBatchingStrategyTransaction.closeAll (react-dom.inc.js:14882)
    at ReactDefaultBatchingStrategyTransaction.perform (react-dom.inc.js:14829)
    at Object.batchedUpdates (react-dom.inc.js:8862)
    at Object.batchedUpdates (react-dom.inc.js:12944)
    at dispatchEvent (react-dom.inc.js:9260)

Which is coming from here:

// ...
  componentWillReceiveProps(nextProps, nextContext) {
    if (this.props.mode === 'inline' &&
        nextProps.mode !== 'inline') {
      this.switchModeFromInline = true;
    }
    if ((nextProps.inlineCollapsed && !this.props.inlineCollapsed) ||
        (nextContext.siderCollapsed && !this.context.siderCollapsed)) { // <-- nextContext
      this.switchModeFromInline = !!this.state.openKeys.length;         //     is null
      this.inlineOpenKeys = this.state.openKeys;
      this.handleOpenChange([]);
}
// ...

I tried adding the context parameter to the relevant methods in omify.core/make-reshape-map and was greeted by Om with this:

Assert failed: Invalid signature for componentWillReceiveProps got [this_12431 next-props__11991__auto__ next-context__11992__auto__], need [this next-props] (= (count sig') (count sig))`.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions