Skip to content

Commit 0c20769

Browse files
committed
feat: do not fallback to Spark for distincts
1 parent f029bf7 commit 0c20769

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

spark/src/test/scala/org/apache/comet/CometFuzzAggregateSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ class CometFuzzAggregateSuite extends CometFuzzTestBase {
7979
}
8080
}
8181

82-
// Not yet supported
82+
// COUNT(distinct x, y, z, ...) not yet supported
8383
// https://github.com/apache/datafusion-comet/issues/2292
8484
test("count distinct multiple values and group by multiple column") {
8585
val df = spark.read.parquet(filename)

spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1031,6 +1031,8 @@ class CometExecSuite extends CometTestBase {
10311031
|GROUP BY key
10321032
""".stripMargin)
10331033

1034+
// The above query uses SUM(DISTINCT) and count(distinct value1, value2)
1035+
// which is not yet supported
10341036
checkSparkAnswer(df)
10351037
val subPlan = stripAQEPlan(df.queryExecution.executedPlan).collectFirst {
10361038
case s: CometHashAggregateExec => s

0 commit comments

Comments
 (0)