Skip to content

Commit 19f07b0

Browse files
authored
fix: Reduce cast.rs and utils.rs logic from parquet_support.rs for experimental native scans (apache#1387)
## Which issue does this PR close? Closes #. ## Rationale for this change Reduces number of test failures in `native_datafusion` and `native_iceberg_compat` modes: - native_datafusion: succeeded 651, failed 27, canceled 2, ignored 54, pending 0 - native_iceberg_compat: succeeded 628, failed 50, canceled 2, ignored 54, pending 0 ## What changes are included in this PR? After staring at conversions and hoisting code from arrow-rs to debug, it turns out we can just use arrow's cast in this case. ## How are these changes tested? Ran `make test-jvm` for `native_datafusion` and `native_iceberg_compat` modes.
1 parent 9113159 commit 19f07b0

File tree

5 files changed

+15
-2160
lines changed

5 files changed

+15
-2160
lines changed

native/Cargo.lock

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

native/core/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ datafusion-comet-spark-expr = { workspace = true }
7676
datafusion-comet-proto = { workspace = true }
7777
object_store = { workspace = true }
7878
url = { workspace = true }
79-
chrono = { workspace = true }
8079
parking_lot = "0.12.3"
8180
datafusion-comet-objectstore-hdfs = { path = "../hdfs", optional = true}
8281

0 commit comments

Comments
 (0)