Skip to content

Commit 44272c7

Browse files
committed
chore: Fallback to Spark for array_reverse for binary
1 parent a84f6bd commit 44272c7

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -776,6 +776,11 @@ class CometArrayExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelp
776776

777777
// https://github.com/apache/datafusion-comet/issues/2612
778778
test("array_reverse - fallback for binary array") {
779+
val fallbackReason = if (CometConf.COMET_NATIVE_SCAN_IMPL.key == "native_scan") {
780+
"Unsupported schema"
781+
} else {
782+
CometArrayReverse.unsupportedReason
783+
}
779784
withTable("t1") {
780785
sql("""create table t1 using parquet as
781786
select cast(null as array<binary>) c1, cast(array() as array<binary>) c2
@@ -784,15 +789,15 @@ class CometArrayExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelp
784789

785790
checkSparkAnswerAndFallbackReason(
786791
"select reverse(array(c1, c2)) AS x FROM t1",
787-
CometArrayReverse.unsupportedReason)
792+
fallbackReason)
788793

789794
checkSparkAnswerAndFallbackReason(
790795
"select reverse(array(c1, c1)) AS x FROM t1",
791-
CometArrayReverse.unsupportedReason)
796+
fallbackReason)
792797

793798
checkSparkAnswerAndFallbackReason(
794799
"select reverse(array(array(c1), array(c2))) AS x FROM t1",
795-
CometArrayReverse.unsupportedReason)
800+
fallbackReason)
796801
}
797802
}
798803
}

0 commit comments

Comments
 (0)