chore: use datafusion impl of hex function (apache#2915)

* impl map_from_entries

* Use datafusion impl of hex function

* Revert "impl map_from_entries"

This reverts commit 768b3e9.

---------

Co-authored-by: Kazantsev Maksim <[email protected]>

Author: kazantsev-maksim

native/core/src/execution/jni_api.rs

@@ -47,6 +47,7 @@ use datafusion_spark::function::datetime::date_sub::SparkDateSub;
 use datafusion_spark::function::hash::sha1::SparkSha1;
 use datafusion_spark::function::hash::sha2::SparkSha2;
 use datafusion_spark::function::math::expm1::SparkExpm1;
+use datafusion_spark::function::math::hex::SparkHex;
 use datafusion_spark::function::string::char::CharFunc;
 use datafusion_spark::function::string::concat::SparkConcat;
 use futures::poll;
@@ -337,6 +338,7 @@ fn register_datafusion_spark_function(session_ctx: &SessionContext) {
     session_ctx.register_udf(ScalarUDF::new_from_impl(SparkSha1::default()));
     session_ctx.register_udf(ScalarUDF::new_from_impl(SparkConcat::default()));
     session_ctx.register_udf(ScalarUDF::new_from_impl(SparkBitwiseNot::default()));
+    session_ctx.register_udf(ScalarUDF::new_from_impl(SparkHex::default()));
 }
 
 /// Prepares arrow arrays for output.

native/spark-expr/src/comet_scalar_funcs.rs

@@ -21,8 +21,8 @@ use crate::math_funcs::checked_arithmetic::{checked_add, checked_div, checked_mu
 use crate::math_funcs::modulo_expr::spark_modulo;
 use crate::{
     spark_array_repeat, spark_ceil, spark_decimal_div, spark_decimal_integral_div, spark_floor,
-    spark_hex, spark_isnan, spark_lpad, spark_make_decimal, spark_read_side_padding, spark_round,
-    spark_rpad, spark_unhex, spark_unscaled_value, EvalMode, SparkBitwiseCount, SparkDateTrunc,
+    spark_isnan, spark_lpad, spark_make_decimal, spark_read_side_padding, spark_round, spark_rpad,
+    spark_unhex, spark_unscaled_value, EvalMode, SparkBitwiseCount, SparkDateTrunc,
     SparkStringSpace,
 };
 use arrow::datatypes::DataType;
@@ -130,10 +130,6 @@ pub fn create_comet_physical_fun_with_eval_mode(
         "make_decimal" => {
             make_comet_scalar_udf!("make_decimal", spark_make_decimal, data_type)
         }
-        "hex" => {
-            let func = Arc::new(spark_hex);
-            make_comet_scalar_udf!("hex", func, without data_type)
-        }
         "unhex" => {
             let func = Arc::new(spark_unhex);
             make_comet_scalar_udf!("unhex", func, without data_type)

native/spark-expr/src/lib.rs

@@ -74,8 +74,8 @@ pub use hash_funcs::*;
 pub use json_funcs::ToJson;
 pub use math_funcs::{
     create_modulo_expr, create_negate_expr, spark_ceil, spark_decimal_div,
-    spark_decimal_integral_div, spark_floor, spark_hex, spark_make_decimal, spark_round,
-    spark_unhex, spark_unscaled_value, CheckOverflow, NegativeExpr, NormalizeNaNAndZero,
+    spark_decimal_integral_div, spark_floor, spark_make_decimal, spark_round, spark_unhex,
+    spark_unscaled_value, CheckOverflow, NegativeExpr, NormalizeNaNAndZero,
 };
 pub use string_funcs::*;
 

native/spark-expr/src/math_funcs/hex.rs

@@ -20,7 +20,6 @@ mod ceil;
 pub(crate) mod checked_arithmetic;
 mod div;
 mod floor;
-pub(crate) mod hex;
 pub mod internal;
 pub mod modulo_expr;
 mod negative;
@@ -32,7 +31,6 @@ pub use ceil::spark_ceil;
 pub use div::spark_decimal_div;
 pub use div::spark_decimal_integral_div;
 pub use floor::spark_floor;
-pub use hex::spark_hex;
 pub use internal::*;
 pub use modulo_expr::create_modulo_expr;
 pub use negative::{create_negate_expr, NegativeExpr};