chore: Fallback to Spark for array_reverse for binary

Author: comphead

spark/src/main/scala/org/apache/comet/serde/arrays.scala

@@ -435,6 +435,25 @@ object CometGetArrayItem extends CometExpressionSerde[GetArrayItem] {
 }
 
 object CometArrayReverse extends CometExpressionSerde[Reverse] with ArraysBase {
+  val unsupportedReason = "reverse on array containing binary is not supported"
+
+  @tailrec
+  private def containsBinary(dt: DataType): Boolean = {
+    dt match {
+      case BinaryType => true
+      case ArrayType(elementType, _) => containsBinary(elementType)
+      case _ => false
+    }
+  }
+
+  override def getSupportLevel(expr: Reverse): SupportLevel = {
+    if (containsBinary(expr.child.dataType)) {
+      Incompatible(Some(unsupportedReason))
+    } else {
+      Compatible(None)
+    }
+  }
+
   override def convert(
       expr: Reverse,
       inputs: Seq[Attribute],
@@ -474,7 +493,7 @@ object CometElementAt extends CometExpressionSerde[ElementAt] {
         .setOneBased(true)
         .setFailOnError(expr.failOnError)
 
-      defaultExpr.foreach(arrayExtractBuilder.setDefaultValue(_))
+      defaultExpr.foreach(arrayExtractBuilder.setDefaultValue)
 
       Some(
         ExprOuterClass.Expr

spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala

@@ -773,4 +773,24 @@ class CometArrayExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelp
       }
     }
   }
+
+  test("array_reverse - fallback for binary array") {
+    withTable("t1") {
+      sql(
+        "create table t1 using parquet as " +
+          "select cast(null as array<binary>) c1, cast(array() as array<binary>) c2 from range(10)")
+
+      checkSparkAnswerAndFallbackReason(
+        "select reverse(array(c1, c2)) AS x FROM t1",
+        CometArrayReverse.unsupportedReason)
+
+      checkSparkAnswerAndFallbackReason(
+        "select reverse(array(c1, c1)) AS x FROM t1",
+        CometArrayReverse.unsupportedReason)
+
+      checkSparkAnswerAndFallbackReason(
+        "select reverse(array(array(c1), array(c2))) AS x FROM t1",
+        CometArrayReverse.unsupportedReason)
+    }
+  }
 }