Skip to content

Commit 928e223

Browse files
committed
chore: Fallback to Spark for windows
1 parent d9dc391 commit 928e223

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

common/src/main/scala/org/apache/comet/CometConf.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ object CometConf extends ShimCometConf {
251251
val COMET_EXEC_EXPAND_ENABLED: ConfigEntry[Boolean] =
252252
createExecEnabledConfig("expand", defaultValue = true)
253253
val COMET_EXEC_WINDOW_ENABLED: ConfigEntry[Boolean] =
254-
createExecEnabledConfig("window", defaultValue = true)
254+
createExecEnabledConfig("window", defaultValue = false)
255255
val COMET_EXEC_TAKE_ORDERED_AND_PROJECT_ENABLED: ConfigEntry[Boolean] =
256256
createExecEnabledConfig("takeOrderedAndProject", defaultValue = true)
257257

spark/src/test/scala/org/apache/comet/exec/CometWindowExecSuite.scala

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ class CometWindowExecSuite extends CometTestBase {
258258
}
259259
}
260260

261-
test("Windows support") {
261+
ignore("Windows support") {
262262
Seq("true", "false").foreach(aqeEnabled =>
263263
withSQLConf(
264264
CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "true",
@@ -284,7 +284,7 @@ class CometWindowExecSuite extends CometTestBase {
284284
s"SELECT $function OVER(order by _2 rows between current row and 1 following) FROM t1")
285285

286286
queries.foreach { query =>
287-
checkSparkAnswerAndOperator(query)
287+
checkSparkAnswerAndFallbackReason(query, "Window expressions are not supported")
288288
}
289289
}
290290
}
@@ -303,7 +303,7 @@ class CometWindowExecSuite extends CometTestBase {
303303

304304
spark.read.parquet(dir.toString).createOrReplaceTempView("window_test")
305305
val df = sql("SELECT a, b, c, COUNT(*) OVER () as cnt FROM window_test")
306-
checkSparkAnswerAndOperator(df)
306+
checkSparkAnswerAndFallbackReason(df, "Window expressions are not supported")
307307
}
308308
}
309309

@@ -319,7 +319,7 @@ class CometWindowExecSuite extends CometTestBase {
319319

320320
spark.read.parquet(dir.toString).createOrReplaceTempView("window_test")
321321
val df = sql("SELECT a, b, c, SUM(c) OVER (PARTITION BY a) as sum_c FROM window_test")
322-
checkSparkAnswerAndOperator(df)
322+
checkSparkAnswerAndFallbackReason(df, "Window expressions are not supported")
323323
}
324324
}
325325

@@ -359,7 +359,7 @@ class CometWindowExecSuite extends CometTestBase {
359359
MAX(c) OVER (ORDER BY b) as max_c
360360
FROM window_test
361361
""")
362-
checkSparkAnswerAndOperator(df)
362+
checkSparkAnswerAndFallbackReason(df, "Window expressions are not supported")
363363
}
364364
}
365365

0 commit comments

Comments
 (0)