Skip to content

Commit e75ab17

Browse files
committed
chore: Expand test coverage for CometWindowsExec
1 parent 223232e commit e75ab17

File tree

2 files changed

+19
-16
lines changed

2 files changed

+19
-16
lines changed

spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,34 +19,37 @@
1919

2020
package org.apache.comet.exec
2121

22-
import org.apache.comet.CometSparkSessionExtensions.{isSpark35Plus, isSpark40Plus}
23-
import org.apache.comet.testing.{DataGenOptions, ParquetGenerator, SchemaGenOptions}
24-
import org.apache.comet.{CometConf, ExtendedExplainInfo}
22+
import java.sql.Date
23+
import java.time.{Duration, Period}
24+
25+
import scala.util.Random
26+
27+
import org.scalactic.source.Position
28+
import org.scalatest.Tag
29+
2530
import org.apache.hadoop.fs.Path
2631
import org.apache.spark.sql._
32+
import org.apache.spark.sql.catalyst.{FunctionIdentifier, TableIdentifier}
2733
import org.apache.spark.sql.catalyst.catalog.{BucketSpec, CatalogStatistics, CatalogTable}
28-
import org.apache.spark.sql.catalyst.expressions.aggregate.{AggregateMode, BloomFilterAggregate}
2934
import org.apache.spark.sql.catalyst.expressions.{Expression, ExpressionInfo, Hex}
30-
import org.apache.spark.sql.catalyst.{FunctionIdentifier, TableIdentifier}
35+
import org.apache.spark.sql.catalyst.expressions.aggregate.{AggregateMode, BloomFilterAggregate}
3136
import org.apache.spark.sql.comet._
3237
import org.apache.spark.sql.comet.execution.shuffle.{CometColumnarShuffle, CometShuffleExchangeExec}
38+
import org.apache.spark.sql.execution.{CollectLimitExec, ProjectExec, SQLExecution, UnionExec}
3339
import org.apache.spark.sql.execution.adaptive.{AdaptiveSparkPlanExec, BroadcastQueryStageExec}
3440
import org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormat
3541
import org.apache.spark.sql.execution.exchange.{BroadcastExchangeExec, ReusedExchangeExec, ShuffleExchangeExec}
3642
import org.apache.spark.sql.execution.joins.{BroadcastHashJoinExec, BroadcastNestedLoopJoinExec, CartesianProductExec, SortMergeJoinExec}
3743
import org.apache.spark.sql.execution.reuse.ReuseExchangeAndSubquery
3844
import org.apache.spark.sql.execution.window.WindowExec
39-
import org.apache.spark.sql.execution.{CollectLimitExec, ProjectExec, SQLExecution, UnionExec}
4045
import org.apache.spark.sql.functions._
4146
import org.apache.spark.sql.internal.SQLConf
4247
import org.apache.spark.sql.internal.SQLConf.SESSION_LOCAL_TIMEZONE
4348
import org.apache.spark.unsafe.types.UTF8String
44-
import org.scalactic.source.Position
45-
import org.scalatest.Tag
4649

47-
import java.sql.Date
48-
import java.time.{Duration, Period}
49-
import scala.util.Random
50+
import org.apache.comet.{CometConf, ExtendedExplainInfo}
51+
import org.apache.comet.CometSparkSessionExtensions.{isSpark35Plus, isSpark40Plus}
52+
import org.apache.comet.testing.{DataGenOptions, ParquetGenerator, SchemaGenOptions}
5053

5154
class CometExecSuite extends CometTestBase {
5255

@@ -331,8 +334,6 @@ class CometExecSuite extends CometTestBase {
331334
}
332335
}
333336

334-
335-
336337
test("fix CometNativeExec.doCanonicalize for ReusedExchangeExec") {
337338
withSQLConf(
338339
CometConf.COMET_EXEC_BROADCAST_FORCE_ENABLED.key -> "true",

spark/src/test/scala/org/apache/comet/exec/CometWindowExecSuite.scala

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,14 @@ package org.apache.comet.exec
2121

2222
import org.scalactic.source.Position
2323
import org.scalatest.Tag
24-
import org.apache.spark.sql.internal.SQLConf
25-
import org.apache.comet.CometConf
24+
2625
import org.apache.hadoop.fs.Path
26+
import org.apache.spark.sql.{CometTestBase, Row}
2727
import org.apache.spark.sql.expressions.Window
2828
import org.apache.spark.sql.functions.{count, lead}
29-
import org.apache.spark.sql.{CometTestBase, Row}
29+
import org.apache.spark.sql.internal.SQLConf
30+
31+
import org.apache.comet.CometConf
3032

3133
class CometWindowExecSuite extends CometTestBase {
3234

0 commit comments

Comments
 (0)