Auto merge of rust-lang#130415 - matthiaskrgr:rollup-xhsu9oq, r=matthiaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#130151 (Use a small runner for msvc-ext2 job)
 - rust-lang#130394 (const: don't ICE when encountering a mutable ref to immutable memory)
 - rust-lang#130409 (tests: more ice tests)

r? `@ghost`
`@rustbot` modify labels: rollup

Author: bors

compiler/rustc_const_eval/src/interpret/validity.rs

@@ -14,14 +14,14 @@ use hir::def::DefKind;
 use rustc_ast::Mutability;
 use rustc_data_structures::fx::FxHashSet;
 use rustc_hir as hir;
+use rustc_middle::bug;
 use rustc_middle::mir::interpret::ValidationErrorKind::{self, *};
 use rustc_middle::mir::interpret::{
     alloc_range, ExpectedKind, InterpError, InvalidMetaKind, Misalignment, PointerKind, Provenance,
     UnsupportedOpInfo, ValidationErrorInfo,
 };
 use rustc_middle::ty::layout::{LayoutCx, LayoutOf, TyAndLayout};
 use rustc_middle::ty::{self, Ty, TyCtxt};
-use rustc_middle::{bug, span_bug};
 use rustc_span::symbol::{sym, Symbol};
 use rustc_target::abi::{
     Abi, FieldIdx, FieldsShape, Scalar as ScalarAbi, Size, VariantIdx, Variants, WrappingRange,
@@ -617,13 +617,7 @@ impl<'rt, 'tcx, M: Machine<'tcx>> ValidityVisitor<'rt, 'tcx, M> {
                         if ptr_expected_mutbl == Mutability::Mut
                             && alloc_actual_mutbl == Mutability::Not
                         {
-                            if !self.ecx.tcx.sess.opts.unstable_opts.unleash_the_miri_inside_of_you
-                            {
-                                span_bug!(
-                                    self.ecx.tcx.span,
-                                    "the static const safety checks accepted mutable references they should not have accepted"
-                                );
-                            }
+                            // This can actually occur with transmutes.
                             throw_validation_failure!(self.path, MutableRefToImmutable);
                         }
                         // In a const, everything must be completely immutable.

src/ci/github-actions/jobs.yml

@@ -24,6 +24,10 @@ runners:
     os: macos-14
     <<: *base-job
 
+  - &job-windows
+    os: windows-2022
+    <<: *base-job
+
   - &job-windows-8c
     os: windows-2022-8core-32gb
     <<: *base-job
@@ -388,7 +392,7 @@ auto:
         python x.py miri --stage 2 library/alloc --test-args notest &&
         python x.py miri --stage 2 library/std --test-args notest
       RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-msvc --enable-lld
-    <<: *job-windows-8c
+    <<: *job-windows
 
   # 32/64-bit MinGW builds.
   #

tests/crashes/129262.rs

@@ -0,0 +1,21 @@
+//@ known-bug: rust-lang/rust#129262
+//@ compile-flags: -Zvalidate-mir --edition=2018 --crate-type=lib -Copt-level=3
+
+#![feature(async_closure)]
+
+fn main() {}
+
+fn needs_fn_mut<T>(mut x: impl FnMut() -> T) {
+    x();
+}
+
+fn hello(x: Ty) {
+    needs_fn_mut(async || {
+        x.hello();
+    });
+}
+
+struct Ty;
+impl Ty {
+    fn hello(self) {}
+}

tests/crashes/129850.rs

@@ -0,0 +1,9 @@
+//@ known-bug: rust-lang/rust#129850
+
+pub trait Foo2 {
+    fn bar<'a: 'a>(&'a mut self) -> impl Sized + use<'static>;
+}
+
+impl Foo2 for () {
+    fn bar<'a: 'a>(&'a mut self) -> impl Sized + 'a {}
+}

tests/crashes/130104.rs

@@ -0,0 +1,6 @@
+//@ known-bug: rust-lang/rust#130104
+
+fn main() {
+    let non_secure_function =
+        core::mem::transmute::<fn() -> _, extern "C-cmse-nonsecure-call" fn() -> _>;
+}

tests/crashes/130310.rs

@@ -0,0 +1,15 @@
+//@ known-bug: rust-lang/rust#130310
+
+use std::marker::PhantomData;
+
+#[repr(C)]
+struct A<T> {
+    a: *const A<A<T>>,
+    p: PhantomData<T>,
+}
+
+extern "C" {
+    fn f(a: *const A<()>);
+}
+
+fn main() {}

tests/crashes/130346.rs

@@ -0,0 +1,10 @@
+//@ known-bug: rust-lang/rust#130346
+
+#![feature(non_lifetime_binders)]
+#![allow(unused)]
+
+trait A<T>: Iterator<Item = T> {}
+
+fn demo(x: &mut impl for<U> A<U>) {
+    let _: Option<u32> = x.next(); // Removing this line stops the ICE
+}

tests/crashes/130372-1.rs

@@ -0,0 +1,9 @@
+//@ known-bug: rust-lang/rust#130372
+
+pub fn variadic_fn(n: usize, mut args: ...) {}
+
+reuse variadic_fn;
+
+fn main() {
+        variadic_fn();
+}

tests/crashes/130372-2.rs

@@ -0,0 +1,11 @@
+//@ known-bug: rust-lang/rust#130372
+
+pub fn test_va_copy(_: u64, mut ap: ...) {}
+
+pub fn main() {
+    unsafe {
+        test_va_copy();
+
+        call(x);
+    }
+}

tests/crashes/130372-3.rs

@@ -0,0 +1,7 @@
+//@ known-bug: rust-lang/rust#130372
+
+fn bar() -> impl Fn() {
+    wrap()
+}
+
+fn wrap(...: impl ...) -> impl Fn() {}