Skip to content

Commit 21ffbcf

Browse files
committed
fix upload to s3
1 parent 3792641 commit 21ffbcf

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

bin/lib/cmake_cache_extractor.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -557,11 +557,19 @@ def extract_cache(
557557
self.logger.info(f" Size: {zip_size_mb} MB")
558558

559559
# Upload to S3 if requested
560-
if upload_to_s3 and compiler_id:
561-
upload_success, upload_message = self.upload_to_s3(zip_file, compiler_id)
562-
if not upload_success:
563-
# Log the error but don't fail the entire operation
564-
self.logger.warning(f"S3 upload failed: {upload_message}")
560+
if upload_to_s3:
561+
if compiler_id:
562+
self.logger.info(f"Uploading ZIP file to S3 for compiler {compiler_id}...")
563+
upload_success, upload_message = self.upload_to_s3(zip_file, compiler_id)
564+
if upload_success:
565+
self.logger.info(f"S3 upload successful: {upload_message}")
566+
else:
567+
# Log the error but don't fail the entire operation
568+
self.logger.warning(f"S3 upload failed: {upload_message}")
569+
else:
570+
self.logger.warning("S3 upload requested but no compiler_id provided for this extraction - skipping upload")
571+
else:
572+
self.logger.debug("S3 upload not requested")
565573

566574
self.logger.info("\nCompiler cache extraction complete!")
567575
self.logger.info("This cache was generated by CMake itself and includes:")

0 commit comments

Comments
 (0)