Skip to content

Conversation

@salva24
Copy link
Collaborator

@salva24 salva24 commented Sep 26, 2025

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 237. Check the log or trigger a new build to see more.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 148. Check the log or trigger a new build to see more.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 123. Check the log or trigger a new build to see more.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@vgvassilev
Copy link
Contributor

Can you compare the runtime before and after this change. I want to make sure we do not do the slow json fetch parameter operation in a hot function somewhere...

@salva24
Copy link
Collaborator Author

salva24 commented Sep 27, 2025

Can you compare the runtime before and after this change. I want to make sure we do not do the slow json fetch parameter operation in a hot function somewhere...

Sure, I am pretty sure the run time is going to be very similar. I only read the json in the beginning and then the parameters are acceded from a struct that extends ParamGroup as BioDynaMo recomends

@github-actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@salva24 salva24 marked this pull request as ready for review September 28, 2025 13:06
@github-actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @salva24!

@vgvassilev vgvassilev merged commit 470a14b into compiler-research:master Sep 29, 2025
3 checks passed
@salva24 salva24 deleted the add_interface_file branch October 23, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants