Merge branch 'main' into improve_test1

Author: mcbarton

lib/Interpreter/CMakeLists.txt

@@ -1,6 +1,5 @@
 if(EMSCRIPTEN)
   set_property(GLOBAL PROPERTY TARGET_SUPPORTS_SHARED_LIBS TRUE)
-  set(CMAKE_STRIP FALSE)
   set(LLVM_LINK_COMPONENTS "")
 else()
   set(LLVM_LINK_COMPONENTS
@@ -129,9 +128,13 @@ if(EMSCRIPTEN)
   #FIXME: A patch is needed to llvm to remove -Wl,-z,defs since it is now recognised on emscripten. What needs to be removed is here
   # https://github.com/llvm/llvm-project/blob/128e2e446e90c3b1827cfc7d4d19e3c0976beff3/llvm/cmake/modules/HandleLLVMOptions.cmake#L318 . The PR to do try to do this is here 
   # https://github.com/llvm/llvm-project/pull/123396
-  set_target_properties(clangCppInterOp PROPERTIES
-    NO_SONAME 1
-    LINK_FLAGS "-s WASM_BIGINT  -s SIDE_MODULE=1 ${SYMBOLS_LIST}"
+  set_target_properties(clangCppInterOp
+    PROPERTIES NO_SONAME 1
+  )
+  target_link_options(clangCppInterOp
+    PRIVATE "SHELL: -s WASM_BIGINT"
+    PRIVATE "SHELL: -s SIDE_MODULE=1"
+    PRIVATE "SHELL: ${SYMBOLS_LIST}"
   )
   if (CPPINTEROP_ENABLE_TESTING)
     # When compiling Emscripten tests the shared library it links to is expected to be in the same folder as the compiled Javascript

unittests/CppInterOp/TestSharedLib/CMakeLists.txt

@@ -11,9 +11,12 @@ set_output_directory(TestSharedLib
 
 
 if (EMSCRIPTEN)
-  set_target_properties(TestSharedLib PROPERTIES
-    NO_SONAME 1
-    LINK_FLAGS "-s WASM_BIGINT  -s SIDE_MODULE=1"
+  set_target_properties(TestSharedLib
+    PROPERTIES NO_SONAME 1
+  )
+  target_link_options(TestSharedLib
+    PRIVATE "SHELL: -s WASM_BIGINT"
+    PRIVATE "SHELL: -s SIDE_MODULE=1"
   )
 endif()