make_dtor_wrapper indicates if codegen fails, add negative case tests

Author: aaronj0

lib/CppInterOp/CppInterOp.cpp

@@ -2986,17 +2986,17 @@ static JitCall::DestructorCall make_dtor_wrapper(compat::Interpreter& interp,
   //
   void* F = compile_wrapper(interp, wrapper_name, wrapper,
                             /*withAccessControl=*/false);
+  LLVM_DEBUG(dbgs() << "Compiled '" << (F ? "" : "un") << "successfully:\n"
+                    << wrapper << "'\n");
   if (F) {
     gDtorWrapperStore.insert(make_pair(D, F));
-  } else {
-    llvm::errs() << "make_dtor_wrapper"
-                 << "Failed to compile\n"
-                 << "==== SOURCE BEGIN ====\n"
-                 << wrapper << "\n  ==== SOURCE END ====";
+    return (JitCall::DestructorCall)F;
   }
-  LLVM_DEBUG(dbgs() << "Compiled '" << (F ? "" : "un") << "successfully:\n"
-                    << wrapper << "'\n");
-  return (JitCall::DestructorCall)F;
+  llvm::errs() << "make_dtor_wrapper"
+               << "Failed to compile\n"
+               << "==== SOURCE BEGIN ====\n"
+               << wrapper << "\n  ==== SOURCE END ====";
+  return (JitCall::DestructorCall) nullptr;
 }
 #undef DEBUG_TYPE
 } // namespace

unittests/CppInterOp/FunctionReflectionTest.cpp

@@ -2406,6 +2406,20 @@ TEST(FunctionReflectionTest, Destruct) {
   // Clean up resources
   clang_Interpreter_takeInterpreterAsPtr(I);
   clang_Interpreter_dispose(I);
+
+  // Failure test, this wrapper should not compile since we explicitly delete
+  // the destructor
+  Interp->declare(R"(
+  class D {
+    public:
+      D() {}
+      ~D() = delete;
+  };
+  )");
+
+  scope = Cpp::GetNamed("D");
+  object = Cpp::Construct(scope);
+  EXPECT_FALSE(Cpp::Destruct(object, scope));
 }
 
 TEST(FunctionReflectionTest, DestructArray) {