Update GetBinaryOperator to GetOperator

resolving unary operators and operators defined within namespaces

Author: Vipul-Cariappa

include/clang/Interpreter/CppInterOp.h

@@ -37,40 +37,59 @@ namespace Cpp {
   using TInterp_t = void*;
   using TCppObject_t = void*;
 
-  enum BinaryOperator {
-    PtrMemD = 0,
-    PtrMemI,
-    Mul,
-    Div,
-    Rem,
-    Add,
-    Sub,
-    Shl,
-    Shr,
-    Cmp,
-    LT,
-    GT,
-    LE,
-    GE,
-    EQ,
-    NE,
-    And,
-    Xor,
-    Or,
-    LAnd,
-    LOr,
-    Assign,
-    MulAssign,
-    DivAssign,
-    RemAssign,
-    AddAssign,
-    SubAssign,
-    ShlAssign,
-    ShrAssign,
-    AndAssign,
-    XorAssign,
-    OrAssign,
-    Comma,
+  enum Operator {
+    OP_None,
+    OP_New,
+    OP_Delete,
+    OP_Array_New,
+    OP_Array_Delete,
+    OP_Plus,
+    OP_Minus,
+    OP_Star,
+    OP_Slash,
+    OP_Percent,
+    OP_Caret,
+    OP_Amp,
+    OP_Pipe,
+    OP_Tilde,
+    OP_Exclaim,
+    OP_Equal,
+    OP_Less,
+    OP_Greater,
+    OP_PlusEqual,
+    OP_MinusEqual,
+    OP_StarEqual,
+    OP_SlashEqual,
+    OP_PercentEqual,
+    OP_CaretEqual,
+    OP_AmpEqual,
+    OP_PipeEqual,
+    OP_LessLess,
+    OP_GreaterGreater,
+    OP_LessLessEqual,
+    OP_GreaterGreaterEqual,
+    OP_EqualEqual,
+    OP_ExclaimEqual,
+    OP_LessEqual,
+    OP_GreaterEqual,
+    OP_Spaceship,
+    OP_AmpAmp,
+    OP_PipePipe,
+    OP_PlusPlus,
+    OP_MinusMinus,
+    OP_Comma,
+    OP_ArrowStar,
+    OP_Arrow,
+    OP_Call,
+    OP_Subscript,
+    OP_Conditional,
+    OP_Coawait,
+  };
+
+  enum OperatorKind {
+    kUnary = 0b001,
+    kBinary = 0b010,
+    kBoth = 0b011,
   };
 
   /// A class modeling function calls for functions produced by the interpreter
@@ -512,9 +531,16 @@ namespace Cpp {
   CPPINTEROP_API std::string GetFunctionArgName(TCppFunction_t func,
                                                 TCppIndex_t param_index);
 
-  ///\returns function that performs operation op on lc and rc
-  void GetBinaryOperator(TCppScope_t scope, enum BinaryOperator op,
-                         std::vector<TCppFunction_t>& operators);
+  ///\returns true if scope is a unary operator
+  bool IsUnaryOperator(TCppScope_t scope);
+
+  ///\returns true if scope is a binary operator
+  bool IsBinaryOperator(TCppScope_t scope);
+
+  ///\returns list of operator overloads
+  void GetOperator(TCppScope_t scope, Operator op,
+                   std::vector<TCppFunction_t>& operators,
+                   OperatorKind kind = kBoth);
 
   /// Creates an instance of the interpreter we need for the various interop
   /// services.

lib/Interpreter/CppInterOp.cpp

@@ -3262,22 +3262,52 @@ namespace Cpp {
     return PI->getNameAsString();
   }
 
-  void GetBinaryOperator(TCppScope_t scope, enum BinaryOperator op,
-                         std::vector<TCppFunction_t>& operators) {
+  bool IsUnaryOperator(TCppScope_t scope) {
     Decl* D = static_cast<Decl*>(scope);
-    auto* DC = llvm::dyn_cast<DeclContext>(D);
-    Scope* S = getSema().getScopeForContext(DC);
-    if (!S)
-      return;
+    if (auto* FD = llvm::dyn_cast<FunctionDecl>(D)) {
+      if (FD->isOverloadedOperator()) {
+        switch (FD->getOverloadedOperator()) {
+#define OVERLOADED_OPERATOR(Name, Spelling, Token, Unary, Binary,            \
+                              MemberOnly)                                      \
+    case OO_##Name:                                                            \
+      return Unary;
+#include "clang/Basic/OperatorKinds.def"
+        }
+      }
+    }
+    return false;
+  }
 
-    clang::UnresolvedSet<8> lookup;
+  bool IsBinaryOperator(TCppScope_t scope) {
+    Decl* D = static_cast<Decl*>(scope);
+    if (auto* FD = llvm::dyn_cast<FunctionDecl>(D)) {
+      if (FD->isOverloadedOperator()) {
+        switch (FD->getOverloadedOperator()) {
+#define OVERLOADED_OPERATOR(Name, Spelling, Token, Unary, Binary,            \
+                              MemberOnly)                                      \
+    case OO_##Name:                                                            \
+      return Binary;
+#include "clang/Basic/OperatorKinds.def"
+        }
+      }
+    }
+    return false;
+  }
 
-    getSema().LookupBinOp(S, SourceLocation(), (clang::BinaryOperatorKind)op,
-                          lookup);
+  void GetOperator(TCppScope_t scope, Operator op,
+                   std::vector<TCppFunction_t>& operators, OperatorKind kind) {
+    Decl* D = static_cast<Decl*>(scope);
+    if (auto* DC = llvm::dyn_cast_or_null<DeclContext>(D)) {
+      ASTContext& C = getSema().getASTContext();
+      DeclContextLookupResult Result =
+          DC->lookup(C.DeclarationNames.getCXXOperatorName(
+              (clang::OverloadedOperatorKind)op));
 
-    for (NamedDecl* D : lookup) {
-      if (auto* FD = llvm::dyn_cast<Decl>(D))
-        operators.push_back(FD);
+      for (auto* i : Result) {
+        if (((kind & OperatorKind::kBinary) && (IsBinaryOperator(i))) ||
+            ((kind & OperatorKind::kUnary) && (IsUnaryOperator(i))))
+          operators.push_back(i);
+      }
     }
   }
 

unittests/CppInterOp/ScopeReflectionTest.cpp

@@ -967,7 +967,7 @@ TEST(ScopeReflectionTest, IncludeVector) {
   Interp->process(code);
 }
 
-TEST(ScopeReflectionTest, GetBinaryOperator) {
+TEST(ScopeReflectionTest, GetOperator) {
   if (llvm::sys::RunningOnValgrind())
     GTEST_SKIP() << "XFAIL due to Valgrind report";
 
@@ -988,27 +988,45 @@ TEST(ScopeReflectionTest, GetBinaryOperator) {
         return MyClass(lhs.x + rhs.x);
     }
 
+    namespace extra_ops {
+
     MyClass operator+(MyClass lhs, int rhs) {
         return MyClass(lhs.x + rhs);
     }
 
     MyClass operator+(int lhs, MyClass rhs) {
         return MyClass(lhs + rhs.x);
     }
+
+    MyClass operator-(MyClass self) {
+        return MyClass(-self.x);
+    }
+
+    }
   )";
 
   Cpp::Declare(code.c_str());
 
   std::vector<Cpp::TCppFunction_t> ops;
 
-  Cpp::GetBinaryOperator(Cpp::GetGlobalScope(), Cpp::BinaryOperator::Add, ops);
-  EXPECT_EQ(ops.size(), 3);
+  Cpp::GetOperator(Cpp::GetGlobalScope(), Cpp::Operator::OP_Plus, ops);
+  EXPECT_EQ(ops.size(), 1);
   ops.clear();
 
-  Cpp::GetBinaryOperator(Cpp::GetGlobalScope(), Cpp::BinaryOperator::Sub, ops);
+  Cpp::GetOperator(Cpp::GetGlobalScope(), Cpp::Operator::OP_Minus, ops);
   EXPECT_EQ(ops.size(), 1);
   ops.clear();
 
-  Cpp::GetBinaryOperator(Cpp::GetGlobalScope(), Cpp::BinaryOperator::Mul, ops);
+  Cpp::GetOperator(Cpp::GetGlobalScope(), Cpp::Operator::OP_Star, ops);
   EXPECT_EQ(ops.size(), 0);
+  ops.clear();
+
+  // operators defined within a namespace
+  Cpp::GetOperator(Cpp::GetScope("extra_ops"), Cpp::Operator::OP_Plus, ops);
+  EXPECT_EQ(ops.size(), 2);
+  ops.clear();
+
+  // unary operator
+  Cpp::GetOperator(Cpp::GetScope("extra_ops"), Cpp::Operator::OP_Minus, ops);
+  EXPECT_EQ(ops.size(), 1);
 }