Skip to content

Commit 5494f4a

Browse files
committed
Remove gmock dependency
1 parent 59a5e99 commit 5494f4a

File tree

3 files changed

+9
-18
lines changed

3 files changed

+9
-18
lines changed

cmake/modules/GoogleTest.cmake

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ set(_gtest_byproduct_binary_dir
33
set(_gtest_byproducts
44
${_gtest_byproduct_binary_dir}/lib/libgtest.a
55
${_gtest_byproduct_binary_dir}/lib/libgtest_main.a
6-
${_gtest_byproduct_binary_dir}/lib/libgmock.a
7-
${_gtest_byproduct_binary_dir}/lib/libgmock_main.a
86
)
97

108
if(WIN32)
@@ -73,12 +71,11 @@ ExternalProject_Add(
7371
TIMEOUT 600
7472
)
7573

76-
# Specify include dirs for gtest and gmock
74+
# Specify include dirs for gtest
7775
ExternalProject_Get_Property(googletest source_dir)
7876
set(GTEST_INCLUDE_DIR ${source_dir}/googletest/include)
79-
set(GMOCK_INCLUDE_DIR ${source_dir}/googlemock/include)
8077
# Create the directories. Prevents bug https://gitlab.kitware.com/cmake/cmake/issues/15052
81-
file(MAKE_DIRECTORY ${GTEST_INCLUDE_DIR} ${GMOCK_INCLUDE_DIR})
78+
file(MAKE_DIRECTORY ${GTEST_INCLUDE_DIR})
8279

8380
# Libraries
8481
ExternalProject_Get_Property(googletest binary_dir)
@@ -88,9 +85,8 @@ else()
8885
set(_G_LIBRARY_PATH ${binary_dir}/lib/)
8986
endif()
9087

91-
# Use gmock_main instead of gtest_main because it initializes gtest as well.
9288
# Note: The libraries are listed in reverse order of their dependencies.
93-
foreach(lib gtest gtest_main gmock gmock_main)
89+
foreach(lib gtest gtest_main)
9490
add_library(${lib} IMPORTED STATIC GLOBAL)
9591
set_target_properties(${lib} PROPERTIES
9692
IMPORTED_LOCATION "${_G_LIBRARY_PATH}${CMAKE_STATIC_LIBRARY_PREFIX}${lib}${CMAKE_STATIC_LIBRARY_SUFFIX}"
@@ -103,9 +99,6 @@ foreach(lib gtest gtest_main gmock gmock_main)
10399
endif()
104100
endforeach()
105101
target_include_directories(gtest INTERFACE ${GTEST_INCLUDE_DIR})
106-
target_include_directories(gmock INTERFACE ${GMOCK_INCLUDE_DIR})
107102

108103
set_property(TARGET gtest PROPERTY IMPORTED_LOCATION ${_G_LIBRARY_PATH}/${CMAKE_STATIC_LIBRARY_PREFIX}gtest${CMAKE_STATIC_LIBRARY_SUFFIX})
109104
set_property(TARGET gtest_main PROPERTY IMPORTED_LOCATION ${_G_LIBRARY_PATH}/${CMAKE_STATIC_LIBRARY_PREFIX}gtest_main${CMAKE_STATIC_LIBRARY_SUFFIX})
110-
set_property(TARGET gmock PROPERTY IMPORTED_LOCATION ${_G_LIBRARY_PATH}/${CMAKE_STATIC_LIBRARY_PREFIX}gmock${CMAKE_STATIC_LIBRARY_SUFFIX})
111-
set_property(TARGET gmock_main PROPERTY IMPORTED_LOCATION ${_G_LIBRARY_PATH}/${CMAKE_STATIC_LIBRARY_PREFIX}gmock_main${CMAKE_STATIC_LIBRARY_SUFFIX})

unittests/CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,16 @@ endif()
1010
if(EMSCRIPTEN)
1111
if (TARGET GTest::gtest)
1212
# Target names in CMake >= v3.23
13-
set(gtest_libs GTest::gtest GTest::gmock)
13+
set(gtest_libs GTest::gtest)
1414
else()
15-
set(gtest_libs gtest gmock)
15+
set(gtest_libs gtest)
1616
endif()
1717
else()
1818
if (TARGET GTest::gtest)
1919
# Target names in CMake >= v3.23
20-
set(gtest_libs GTest::gtest GTest::gmock GTest::gtest_main)
20+
set(gtest_libs GTest::gtest GTest::gtest_main)
2121
else()
22-
set(gtest_libs gtest gtest_main gmock)
22+
set(gtest_libs gtest gtest_main)
2323
endif()
2424
set(link_pthreads_lib pthread)
2525
endif()

unittests/CppInterOp/InterpreterTest.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,13 @@
2020
#include "llvm/Support/Path.h"
2121
#include <llvm/Support/FileSystem.h>
2222

23-
#include <gmock/gmock.h>
2423
#include "gtest/gtest.h"
2524

2625
#include <algorithm>
2726

28-
using ::testing::StartsWith;
29-
3027
TEST(InterpreterTest, Version) {
31-
EXPECT_THAT(Cpp::GetVersion(), StartsWith("CppInterOp version"));
28+
std::string version = Cpp::GetVersion();
29+
EXPECT_TRUE(version.rfind("CppInterOp version", 0) == 0);
3230
}
3331

3432
#ifdef NDEBUG

0 commit comments

Comments
 (0)