Skip to content

Commit 73bc361

Browse files
authored
Explain why shared library is copied over the unittests folder
1 parent 0349616 commit 73bc361

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

lib/Interpreter/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ if(EMSCRIPTEN)
120120

121121
# Replace newlines with spaces
122122
string(REPLACE "\n" " " SYMBOLS_LIST "${SYMBOLS_LIST}")
123+
123124
#FIXME: Setting no_soname=1 is needed until https://github.com/emscripten-core/emscripten/blob/ac676d5e437525d15df5fd46bc2c208ec6d376a3/cmake/Modules/Platform/Emscripten.cmake#L36
124125
# is patched out of emsdk, as --soname is not recognised by emscripten. A PR to do this has been done here https://github.com/emscripten-core/emscripten/pull/23453
125126
#FIXME: A patch is needed to llvm to remove -Wl,-z,defs since it is now recognised on emscripten. What needs to be removed is here
@@ -131,7 +132,7 @@ if(EMSCRIPTEN)
131132
LINK_FLAGS "-s WASM_BIGINT -s SIDE_MODULE=1 ${SYMBOLS_LIST}"
132133
SUFFIX ".wasm"
133134
)
134-
135+
# When compiling Emscripten tests the shared library as the compiled Javascript
135136
add_custom_command(TARGET clangCppInterOp POST_BUILD
136137
COMMAND ${CMAKE_COMMAND} -E copy $<TARGET_FILE:clangCppInterOp> ${CMAKE_BINARY_DIR}/unittests/CppInterOp/
137138
)

0 commit comments

Comments
 (0)