Skip to content

Commit abbd207

Browse files
authored
Reduce formatting and repetition unittests/CppInterOp/CMakeLists.txt
1 parent 092eddd commit abbd207

File tree

1 file changed

+15
-31
lines changed

1 file changed

+15
-31
lines changed

unittests/CppInterOp/CMakeLists.txt

Lines changed: 15 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ if (EMSCRIPTEN)
99
else()
1010
# Do not need main.cpp for native builds, but we do have GPU support for native builds
1111
set(EXTRA_TEST_SOURCE_FILES CUDATest.cpp)
12+
set(EXTRA_PATH_TEST_BINARIES /unittests/bin/$<CONFIG>/)
1213
endif()
1314

1415
add_cppinterop_unittest(CppInterOpTests
@@ -39,22 +40,16 @@ if(EMSCRIPTEN)
3940
LINK_FLAGS "-s MAIN_MODULE=1 -s WASM_BIGINT -s EXPORTED_RUNTIME_METHODS='[\"FS\",\"PATH\",\"LDSO\",\"loadDynamicLibrary\",\"ERRNO_CODES\"]' --preload-file ${SYSROOT_PATH}/include@/include -s ALLOW_MEMORY_GROWTH=1"
4041
)
4142
endif()
42-
target_link_libraries(CppInterOpTests
43-
PRIVATE
44-
clangCppInterOp
45-
)
4643

47-
IF(EMSCRIPTEN)
48-
set_output_directory(CppInterOpTests
49-
BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}
50-
LIBRARY_DIR ${CMAKE_CURRENT_BINARY_DIR}
51-
)
52-
else()
53-
set_output_directory(CppInterOpTests
54-
BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/CppInterOpTests/unittests/bin/$<CONFIG>/
55-
LIBRARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/CppInterOpTests/unittests/bin/$<CONFIG>/
56-
)
57-
endif()
44+
target_link_libraries(CppInterOpTests
45+
PRIVATE
46+
clangCppInterOp
47+
)
48+
49+
set_output_directory(CppInterOpTests
50+
BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${EXTRA_PATH_TEST_BINARIES}
51+
LIBRARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${EXTRA_PATH_TEST_BINARIES}
52+
)
5853

5954
if(NOT WIN32)
6055
set_source_files_properties(VariableReflectionTest.cpp PROPERTIES COMPILE_FLAGS
@@ -69,11 +64,7 @@ export_executable_symbols(CppInterOpTests)
6964

7065
unset(LLVM_LINK_COMPONENTS)
7166

72-
if(EMSCRIPTEN)
73-
add_cppinterop_unittest(DynamicLibraryManagerTests DynamicLibraryManagerTest.cpp ${EXTRA_TEST_SOURCE_FILES})
74-
else()
75-
add_cppinterop_unittest(DynamicLibraryManagerTests DynamicLibraryManagerTest.cpp)
76-
endif()
67+
add_cppinterop_unittest(DynamicLibraryManagerTests DynamicLibraryManagerTest.cpp ${EXTRA_TEST_SOURCE_FILES})
7768

7869
target_link_libraries(DynamicLibraryManagerTests
7970
PRIVATE
@@ -95,17 +86,10 @@ if(EMSCRIPTEN)
9586
)
9687
endif()
9788

98-
IF(EMSCRIPTEN)
99-
set_output_directory(DynamicLibraryManagerTests
100-
BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}
101-
LIBRARY_DIR ${CMAKE_CURRENT_BINARY_DIR}
102-
)
103-
else()
104-
set_output_directory(DynamicLibraryManagerTests
105-
BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/TestSharedLib/unittests/bin/$<CONFIG>/
106-
LIBRARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/TestSharedLib/unittests/bin/$<CONFIG>/
107-
)
108-
endif()
89+
set_output_directory(DynamicLibraryManagerTests
90+
BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${EXTRA_PATH_TEST_BINARIES}
91+
LIBRARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${EXTRA_PATH_TEST_BINARIES}
92+
)
10993

11094
add_dependencies(DynamicLibraryManagerTests TestSharedLib)
11195

0 commit comments

Comments
 (0)