Skip to content

Commit bf10f8a

Browse files
authored
Fix XEUS_CPP_RESOURCE_DIR in Emscripten build instructions (#687)
1 parent b6a1c08 commit bf10f8a

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

Emscripten-build-instructions.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -320,12 +320,13 @@ emmake make -j $(nproc --all) install
320320
## Xeus-cpp-lite Wasm Build Instructions
321321

322322
A project which makes use of the wasm build of CppInterOp is xeus-cpp. xeus-cpp is a C++ Jupyter kernel. Assuming you are in
323-
the CppInterOp build folder, you can build the wasm version of xeus-cpp by executing (replace $LLVM_VERSION with the version
323+
the CppInterOp build folder, you can build the wasm version of xeus-cpp by executing (replace LLVM_VERSION with the version
324324
of llvm you are building against)
325325

326326
```bash
327327
cd ../..
328328
git clone --depth=1 https://github.com/compiler-research/xeus-cpp.git
329+
export LLVM_VERSION=20
329330
cd ./xeus-cpp
330331
mkdir build
331332
cd build
@@ -335,7 +336,7 @@ emcmake cmake \
335336
-DCMAKE_INSTALL_PREFIX=$PREFIX \
336337
-DXEUS_CPP_EMSCRIPTEN_WASM_BUILD=ON \
337338
-DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=ON \
338-
-DXEUS_CPP_RESOURCE_DIR=$LLVM_BUILD_DIR/lib/clang/$LLVM_VERSION \
339+
-DXEUS_CPP_RESOURCE_DIR="$LLVM_BUILD_DIR/lib/clang/$LLVM_VERSION" \
339340
-DSYSROOT_PATH=$SYSROOT_PATH \
340341
..
341342
emmake make -j $(nproc --all) install

docs/Emscripten-build-instructions.rst

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -342,12 +342,13 @@ Assuming it passes all test you can install by executing the following.
342342
A project which makes use of the wasm build of CppInterOp is xeus-cpp.
343343
xeus-cpp is a C++ Jupyter kernel. Assuming you are in the CppInterOp
344344
build folder, you can build the wasm version of xeus-cpp by executing
345-
(replace $LLVM_VERSION with the version of llvm you are building against)
345+
(replace LLVM_VERSION with the version of llvm you are building against)
346346

347347
.. code:: bash
348348
349349
cd ../..
350350
git clone --depth=1 https://github.com/compiler-research/xeus-cpp.git
351+
export LLVM_VERSION=20
351352
cd ./xeus-cpp
352353
mkdir build
353354
cd build
@@ -357,7 +358,7 @@ build folder, you can build the wasm version of xeus-cpp by executing
357358
-DCMAKE_INSTALL_PREFIX=$PREFIX \
358359
-DXEUS_CPP_EMSCRIPTEN_WASM_BUILD=ON \
359360
-DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=ON \
360-
-DXEUS_CPP_RESOURCE_DIR=$LLVM_BUILD_DIR/lib/clang/$LLVM_VERSION \
361+
-DXEUS_CPP_RESOURCE_DIR="$LLVM_BUILD_DIR/lib/clang/$LLVM_VERSION" \
361362
-DSYSROOT_PATH=$SYSROOT_PATH \
362363
..
363364
emmake make -j $(nproc --all) install

0 commit comments

Comments
 (0)