Skip to content

Commit d606c8f

Browse files
Revert "Add TInterp_t argument to funcs to resolve interpreter instance"
This reverts commit db363c6.
1 parent 74bcb4a commit d606c8f

File tree

2 files changed

+122
-216
lines changed

2 files changed

+122
-216
lines changed

include/CppInterOp/CppInterOp.h

Lines changed: 23 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ CPPINTEROP_API std::string GetQualifiedCompleteName(TCppScope_t klass);
389389
CPPINTEROP_API std::vector<TCppScope_t> GetUsingNamespaces(TCppScope_t scope);
390390

391391
/// Gets the global scope of the whole C++ instance.
392-
CPPINTEROP_API TCppScope_t GetGlobalScope(TInterp_t interp = nullptr);
392+
CPPINTEROP_API TCppScope_t GetGlobalScope();
393393

394394
/// Strips the typedef and returns the underlying class, and if the
395395
/// underlying decl is not a class it returns the input unchanged.
@@ -398,28 +398,18 @@ CPPINTEROP_API TCppScope_t GetUnderlyingScope(TCppScope_t scope);
398398
/// Gets the namespace or class (by stripping typedefs) for the name
399399
/// passed as a parameter, and if the parent is not passed,
400400
/// then global scope will be assumed.
401-
/// Looks up the name in parent, if parent is nullptr,
402-
/// interp is used to select the interpreter if multiple in-use.
403-
/// interp is ignored if parent is non-null.
404401
CPPINTEROP_API TCppScope_t GetScope(const std::string& name,
405-
TCppScope_t parent = nullptr,
406-
TInterp_t interp = nullptr);
402+
TCppScope_t parent = nullptr);
407403

408404
/// When the namespace is known, then the parent doesn't need
409405
/// to be specified. This will probably be phased-out in
410406
/// future versions of the interop library.
411-
/// interp is used to select the interpreter if multiple in-use.
412-
CPPINTEROP_API TCppScope_t GetScopeFromCompleteName(const std::string& name,
413-
TInterp_t interp = nullptr);
407+
CPPINTEROP_API TCppScope_t GetScopeFromCompleteName(const std::string& name);
414408

415409
/// This function performs a lookup within the specified parent,
416410
/// a specific named entity (functions, enums, etcetera).
417-
/// Looks up the name in parent, if parent is nullptr,
418-
/// interp is used to select the interpreter if multiple in-use.
419-
/// interp is ignored if parent is non-null.
420411
CPPINTEROP_API TCppScope_t GetNamed(const std::string& name,
421-
TCppScope_t parent = nullptr,
422-
TInterp_t interp = nullptr);
412+
TCppScope_t parent = nullptr);
423413

424414
/// Gets the parent of the scope that is passed as a parameter.
425415
CPPINTEROP_API TCppScope_t GetParentScope(TCppScope_t scope);
@@ -503,12 +493,8 @@ CPPINTEROP_API bool IsTemplatedFunction(TCppFunction_t func);
503493

504494
/// This function performs a lookup to check if there is a
505495
/// templated function of that type.
506-
/// Looks up the name in parent, if parent is nullptr,
507-
/// interp is used to select the interpreter if multiple in-use.
508-
/// interp is ignored if parent is non-null.
509496
CPPINTEROP_API bool ExistsFunctionTemplate(const std::string& name,
510-
TCppScope_t parent = nullptr,
511-
TInterp_t interp = nullptr);
497+
TCppScope_t parent = nullptr);
512498

513499
/// Sets a list of all the constructor for a scope/class that is
514500
/// supplied as a parameter.
@@ -556,8 +542,7 @@ CPPINTEROP_API bool IsDestructor(TCppConstFunction_t method);
556542
CPPINTEROP_API bool IsStaticMethod(TCppConstFunction_t method);
557543

558544
///\returns the address of the function given its potentially mangled name.
559-
CPPINTEROP_API TCppFuncAddr_t GetFunctionAddress(const char* mangled_name,
560-
TInterp_t interp = nullptr);
545+
CPPINTEROP_API TCppFuncAddr_t GetFunctionAddress(const char* mangled_name);
561546

562547
///\returns the address of the function given its function declaration.
563548
CPPINTEROP_API TCppFuncAddr_t GetFunctionAddress(TCppFunction_t method);
@@ -658,9 +643,7 @@ CPPINTEROP_API TCppType_t GetCanonicalType(TCppType_t type);
658643

659644
/// Used to either get the built-in type of the provided string, or
660645
/// use the name to lookup the actual type.
661-
/// interp is used to select the interpreter if multiple in-use.
662-
CPPINTEROP_API TCppType_t GetType(const std::string& type,
663-
TInterp_t interp = nullptr);
646+
CPPINTEROP_API TCppType_t GetType(const std::string& type);
664647

665648
///\returns the complex of the provided type.
666649
CPPINTEROP_API TCppType_t GetComplexType(TCppType_t element_type);
@@ -744,10 +727,10 @@ CPPINTEROP_API void UseExternalInterpreter(TInterp_t I);
744727

745728
/// Adds a Search Path for the Interpreter to get the libraries.
746729
CPPINTEROP_API void AddSearchPath(const char* dir, bool isUser = true,
747-
bool prepend = false, TInterp_t I = nullptr);
730+
bool prepend = false);
748731

749732
/// Returns the resource-dir path (for headers).
750-
CPPINTEROP_API const char* GetResourceDir(TInterp_t I = nullptr);
733+
CPPINTEROP_API const char* GetResourceDir();
751734

752735
/// Uses the underlying clang compiler to detect the resource directory.
753736
/// In essence calling clang -print-resource-dir and checks if it ends with
@@ -768,52 +751,46 @@ DetectSystemCompilerIncludePaths(std::vector<std::string>& Paths,
768751

769752
/// Secondary search path for headers, if not found using the
770753
/// GetResourceDir() function.
771-
CPPINTEROP_API void AddIncludePath(const char* dir, TInterp_t I = nullptr);
754+
CPPINTEROP_API void AddIncludePath(const char* dir);
772755

773756
// Gets the currently used include paths
774757
///\param[out] IncludePaths - the list of include paths
775758
///
776759
CPPINTEROP_API void GetIncludePaths(std::vector<std::string>& IncludePaths,
777760
bool withSystem = false,
778-
bool withFlags = false,
779-
TInterp_t I = nullptr);
761+
bool withFlags = false);
780762

781763
/// Only Declares a code snippet in \c code and does not execute it.
782764
///\returns 0 on success
783-
CPPINTEROP_API int Declare(const char* code, bool silent = false,
784-
TInterp_t I = nullptr);
765+
CPPINTEROP_API int Declare(const char* code, bool silent = false);
785766

786767
/// Declares and executes a code snippet in \c code.
787768
///\returns 0 on success
788-
CPPINTEROP_API int Process(const char* code, TInterp_t I = nullptr);
769+
CPPINTEROP_API int Process(const char* code);
789770

790771
/// Declares, executes and returns the execution result as a intptr_t.
791772
///\returns the expression results as a intptr_t.
792-
CPPINTEROP_API intptr_t Evaluate(const char* code, bool* HadError = nullptr,
793-
TInterp_t I = nullptr);
773+
CPPINTEROP_API intptr_t Evaluate(const char* code, bool* HadError = nullptr);
794774

795775
/// Looks up the library if access is enabled.
796776
///\returns the path to the library.
797-
CPPINTEROP_API std::string LookupLibrary(const char* lib_name,
798-
TInterp_t I = nullptr);
777+
CPPINTEROP_API std::string LookupLibrary(const char* lib_name);
799778

800779
/// Finds \c lib_stem considering the list of search paths and loads it by
801780
/// calling dlopen.
802781
/// \returns true on success.
803-
CPPINTEROP_API bool LoadLibrary(const char* lib_stem, bool lookup = true,
804-
TInterp_t I = nullptr);
782+
CPPINTEROP_API bool LoadLibrary(const char* lib_stem, bool lookup = true);
805783

806784
/// Finds \c lib_stem considering the list of search paths and unloads it by
807785
/// calling dlclose.
808786
/// function.
809-
CPPINTEROP_API void UnloadLibrary(const char* lib_stem, TInterp_t I = nullptr);
787+
CPPINTEROP_API void UnloadLibrary(const char* lib_stem);
810788

811789
/// Scans all libraries on the library search path for a given potentially
812790
/// mangled symbol name.
813791
///\returns the path to the first library that contains the symbol definition.
814-
CPPINTEROP_API std::string SearchLibrariesForSymbol(const char* mangled_name,
815-
bool search_system /*true*/,
816-
TInterp_t I = nullptr);
792+
CPPINTEROP_API std::string
793+
SearchLibrariesForSymbol(const char* mangled_name, bool search_system /*true*/);
817794

818795
/// Inserts or replaces a symbol in the JIT with the one provided. This is
819796
/// useful for providing our own implementations of facilities such as printf.
@@ -824,8 +801,7 @@ CPPINTEROP_API std::string SearchLibrariesForSymbol(const char* mangled_name,
824801
///
825802
///\returns true on failure.
826803
CPPINTEROP_API bool InsertOrReplaceJitSymbol(const char* linker_mangled_name,
827-
uint64_t address,
828-
TInterp_t I = nullptr);
804+
uint64_t address);
829805

830806
/// Tries to load provided objects in a string format (prettyprint).
831807
CPPINTEROP_API std::string ObjToString(const char* type, void* obj);
@@ -862,10 +838,9 @@ GetClassTemplateInstantiationArgs(TCppScope_t templ_instance,
862838

863839
/// Instantiates a function template from a given string representation. This
864840
/// function also does overload resolution.
865-
///\param[in] interp - is used to select the interpreter if multiple in-use.
866841
///\returns the instantiated function template declaration.
867-
CPPINTEROP_API TCppFunction_t InstantiateTemplateFunctionFromString(
868-
const char* function_template, TInterp_t interp = nullptr);
842+
CPPINTEROP_API TCppFunction_t
843+
InstantiateTemplateFunctionFromString(const char* function_template);
869844

870845
/// Finds best overload match based on explicit template parameters (if any)
871846
/// and argument types.
@@ -963,7 +938,7 @@ CPPINTEROP_API void CodeComplete(std::vector<std::string>& Results,
963938
/// Reverts the last N operations performed by the interpreter.
964939
///\param[in] N The number of operations to undo. Defaults to 1.
965940
///\returns 0 on success, non-zero on failure.
966-
CPPINTEROP_API int Undo(unsigned N = 1, TInterp_t interp = nullptr);
941+
CPPINTEROP_API int Undo(unsigned N = 1);
967942

968943
} // end namespace Cpp
969944

0 commit comments

Comments
 (0)