Add extra diagnostics in JitCall::AreArgumentsValid

This catches 0 objects to construct/destruct and attempting array new with requried initialization parameters

Author: aaronj0

include/CppInterOp/CppInterOp.h

@@ -140,8 +140,8 @@ class JitCall {
       : m_DestructorCall(C), m_Kind(K), m_FD(Dtor) {}
 
   /// Checks if the passed arguments are valid for the given function.
-  CPPINTEROP_API bool AreArgumentsValid(void* result, ArgList args,
-                                        void* self) const;
+  CPPINTEROP_API bool AreArgumentsValid(void* result, ArgList args, void* self,
+                                        size_t nary = 1UL) const;
 
   /// This function is used for debugging, it reports when the function was
   /// called.
@@ -205,6 +205,7 @@ class JitCall {
                         int withFree = true) const {
     assert(m_Kind == kDestructorCall && "Wrong overload!");
 #ifndef NDEBUG
+    assert(AreArgumentsValid(/*result*/nullptr, /*args*/{}, object, nary) && "Invalid args!");
     ReportInvokeStart(object, nary, withFree);
 #endif // NDEBUG
     m_DestructorCall(object, nary, withFree);
@@ -221,7 +222,7 @@ class JitCall {
                          ArgList args = {}, void* is_arena = nullptr) const {
     assert(m_Kind == kConstructorCall && "Wrong overload!");
 #ifndef NDEBUG
-    assert(AreArgumentsValid(result, args, nullptr, nary) && "Invalid args!");
+    assert(AreArgumentsValid(result, args, /*self=*/nullptr, nary) && "Invalid args!");
     ReportInvokeStart(result, args, nullptr);
 #endif // NDEBUG
     m_ConstructorCall(result, nary, args.m_ArgSize, args.m_Args, is_arena);

lib/CppInterOp/CppInterOp.cpp

@@ -133,7 +133,8 @@ static clang::Sema& getSema() { return getInterp().getCI()->getSema(); }
 static clang::ASTContext& getASTContext() { return getSema().getASTContext(); }
 
 #define DEBUG_TYPE "jitcall"
-bool JitCall::AreArgumentsValid(void* result, ArgList args, void* self) const {
+bool JitCall::AreArgumentsValid(void* result, ArgList args, void* self,
+                                size_t nary) const {
   bool Valid = true;
   if (Cpp::IsConstructor(m_FD)) {
     assert(result && "Must pass the location of the created object!");
@@ -157,6 +158,18 @@ bool JitCall::AreArgumentsValid(void* result, ArgList args, void* self) const {
     assert(0 && "We are discarding the return type of the function!");
     Valid = false;
   }
+  if (Cpp::IsConstructor(m_FD) && nary == 0UL) {
+    assert(0 && "Number of objects to construct should be atleast 1");
+    Valid = false;
+  }
+  if (Cpp::IsConstructor(m_FD)) {
+    const auto* CD = cast<CXXConstructorDecl>((const Decl*)m_FD);
+    if (CD->getMinRequiredArguments() != 0 && nary > 1) {
+      assert(0 &&
+             "Cannot pass initialization parameters to array new construction");
+      Valid = false;
+    }
+  }
   assert(m_Kind != kDestructorCall && "Wrong overload!");
   Valid &= m_Kind != kDestructorCall;
   return Valid;