Skip to content

Commit eccc90a

Browse files
mcbartonvgvassilev
authored andcommitted
Remove CPPINTEROP_BUILD_DIR Emscripten build instructions
1 parent 993550c commit eccc90a

File tree

4 files changed

+0
-21
lines changed

4 files changed

+0
-21
lines changed

.github/workflows/deploy-pages.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ jobs:
116116
# Build CppInterOp next to cling and llvm-project.
117117
mkdir build
118118
cd build
119-
export CPPINTEROP_BUILD_DIR=$PWD
120119
121120
if [[ "${cling_on}" == "ON" ]]; then
122121
emcmake cmake -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} \
@@ -153,7 +152,6 @@ jobs:
153152
154153
echo "SYSROOT_PATH=$SYSROOT_PATH" >> $GITHUB_ENV
155154
echo "CB_PYTHON_DIR=$CB_PYTHON_DIR" >> $GITHUB_ENV
156-
echo "CPPINTEROP_BUILD_DIR=$CPPINTEROP_BUILD_DIR" >> $GITHUB_ENV
157155
echo "CPPINTEROP_DIR=$CPPINTEROP_DIR" >> $GITHUB_ENV
158156
echo "LLVM_BUILD_DIR=$LLVM_BUILD_DIR" >> $GITHUB_ENV
159157
echo "CPLUS_INCLUDE_PATH=$CPLUS_INCLUDE_PATH" >> $GITHUB_ENV
@@ -177,7 +175,6 @@ jobs:
177175
-DCMAKE_INSTALL_PREFIX=${{ env.PREFIX }} \
178176
-DXEUS_CPP_EMSCRIPTEN_WASM_BUILD=ON \
179177
-DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=ON \
180-
-DCppInterOp_DIR="${{ env.CPPINTEROP_BUILD_DIR }}/lib/cmake/CppInterOp" \
181178
-DSYSROOT_PATH=${{ env.SYSROOT_PATH }} \
182179
..
183180
emmake make -j ${{ env.ncpus }} install

.github/workflows/emscripten.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,6 @@ jobs:
571571
# Build CppInterOp next to cling and llvm-project.
572572
mkdir build
573573
cd build
574-
export CPPINTEROP_BUILD_DIR=$PWD
575574
if [[ "${cling_on}" == "ON" ]]; then
576575
emcmake cmake -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} \
577576
-DCPPINTEROP_USE_CLING=ON \
@@ -609,7 +608,6 @@ jobs:
609608
610609
echo "SYSROOT_PATH=$SYSROOT_PATH" >> $GITHUB_ENV
611610
echo "CB_PYTHON_DIR=$CB_PYTHON_DIR" >> $GITHUB_ENV
612-
echo "CPPINTEROP_BUILD_DIR=$CPPINTEROP_BUILD_DIR" >> $GITHUB_ENV
613611
echo "CPPINTEROP_DIR=$CPPINTEROP_DIR" >> $GITHUB_ENV
614612
echo "LLVM_BUILD_DIR=$LLVM_BUILD_DIR" >> $GITHUB_ENV
615613
echo "CPLUS_INCLUDE_PATH=$CPLUS_INCLUDE_PATH" >> $GITHUB_ENV
@@ -633,7 +631,6 @@ jobs:
633631
-DCMAKE_INSTALL_PREFIX=${{ env.PREFIX }} \
634632
-DXEUS_CPP_EMSCRIPTEN_WASM_BUILD=ON \
635633
-DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=ON \
636-
-DCppInterOp_DIR="${{ env.CPPINTEROP_BUILD_DIR }}/lib/cmake/CppInterOp" \
637634
-DSYSROOT_PATH=${{ env.SYSROOT_PATH }} \
638635
..
639636
emmake make -j ${{ env.ncpus }} install

Emscripten-build-instructions.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -121,12 +121,6 @@ Assuming it passes all test you can install by executing the following
121121
emmake make -j $(nproc --all) install
122122
```
123123

124-
Once this finishes building we need to take note of where we built CppInterOp. This can be done by executing the following
125-
126-
```bash
127-
export CPPINTEROP_BUILD_DIR=$PWD
128-
```
129-
130124
## Xeus-cpp-lite Wasm Build Instructions
131125

132126
A project which makes use of the wasm build of CppInterOp is xeus-cpp. xeus-cpp is a C++ Jupyter kernel. Assuming you are in
@@ -144,7 +138,6 @@ emcmake cmake \
144138
-DCMAKE_INSTALL_PREFIX=$PREFIX \
145139
-DXEUS_CPP_EMSCRIPTEN_WASM_BUILD=ON \
146140
-DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=ON \
147-
-DCppInterOp_DIR="$CPPINTEROP_BUILD_DIR/lib/cmake/CppInterOp" \
148141
-DSYSROOT_PATH=$SYSROOT_PATH \
149142
..
150143
emmake make -j $(nproc --all) install

docs/Emscripten-build-instructions.rst

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -139,13 +139,6 @@ Assuming it passes all test you can install by executing the following.
139139
140140
emmake make -j $(nproc --all) install
141141
142-
Once this finishes building we need to take note of where we built
143-
CppInterOp. This can be done by executing the following
144-
145-
.. code:: bash
146-
147-
export CPPINTEROP_BUILD_DIR=$PWD
148-
149142
## Xeus-cpp-lite Wasm Build Instructions
150143

151144
A project which makes use of the wasm build of CppInterOp is xeus-cpp.
@@ -165,7 +158,6 @@ build folder, you can build the wasm version of xeus-cpp by executing
165158
-DCMAKE_INSTALL_PREFIX=$PREFIX \
166159
-DXEUS_CPP_EMSCRIPTEN_WASM_BUILD=ON \
167160
-DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=ON \
168-
-DCppInterOp_DIR="$CPPINTEROP_BUILD_DIR/lib/cmake/CppInterOp" \
169161
-DSYSROOT_PATH=$SYSROOT_PATH \
170162
..
171163
emmake make -j $(nproc --all) install

0 commit comments

Comments
 (0)