Skip to content

Commit fd3ccf5

Browse files
committed
[DO NOT MERGE] skipped still-reachable memory in valgrind
1 parent c34f786 commit fd3ccf5

File tree

1 file changed

+2
-12
lines changed
  • .github/actions/Build_and_Test_CppInterOp

1 file changed

+2
-12
lines changed

.github/actions/Build_and_Test_CppInterOp/action.yml

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
name: 'Builds and test CppInterOp'
22
description: 'This action builds and tests CppInterOp for native platforms'
33

4-
# REVERT BEFORE MERGING
54
runs:
65
using: composite
76
steps:
@@ -60,18 +59,9 @@ runs:
6059
cmake --build . --target check-cppinterop --parallel ${{ env.ncpus }}
6160
os="${{ matrix.os }}"
6261
if [[ "${os}" != "macos"* ]]; then
63-
valgrind \
64-
--leak-check=full \
65-
--show-leak-kinds=all \
66-
--track-origins=yes \
67-
--gen-suppressions=all \
68-
--log-file=valgrind-raw.log \
62+
valgrind --show-error-list=yes --track-origins=yes --error-exitcode=1 \
63+
--leak-check=full --show-leak-kinds=definite,possible \
6964
unittests/CppInterOp/CppInterOpTests/unittests/bin/${{ env.BUILD_TYPE }}/CppInterOpTests
70-
71-
grep -A 20 "^{$" valgrind-raw.log > suppressions.supp
72-
73-
echo "======= Valgrind log (for suppression generation) ======="
74-
cat suppressions.supp
7565
fi
7666
fi
7767
echo "CB_PYTHON_DIR=$CB_PYTHON_DIR" >> $GITHUB_ENV

0 commit comments

Comments
 (0)