Implement Demangle and IsClassPolymorphic APIs
#451
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lib/Interpreter/CppInterOp.cpp
Outdated
| std::string DemangleSymbol(const std::string& mangled_name) { | ||
| char* demangle = itaniumDemangle(mangled_name); | ||
| std::string res(demangle); | ||
| std::free(demangle); |
There was a problem hiding this comment.
warning: calling legacy resource function without passing a 'gsl::owner<>' [cppcoreguidelines-owning-memory]
std::free(demangle);
^
There was a problem hiding this comment.
We should just assign to std::string
lib/Interpreter/CppInterOp.cpp
Outdated
| std::string DemangleSymbol(const std::string& mangled_name) { | ||
| char* demangle = itaniumDemangle(mangled_name); | ||
| std::string res(demangle); | ||
| std::free(demangle); |
There was a problem hiding this comment.
warning: do not manage memory manually; use RAII [cppcoreguidelines-no-malloc]
std::free(demangle);
^
lib/Interpreter/CppInterOp.cpp
Outdated
| std::string DemangleSymbol(const std::string& mangled_name) { | ||
| char* demangle = itaniumDemangle(mangled_name); | ||
| std::string res(demangle); | ||
| std::free(demangle); |
There was a problem hiding this comment.
warning: no header providing "std::free" is directly included [misc-include-cleaner]
lib/Interpreter/CppInterOp.cpp:26:
- #if CLANG_VERSION_MAJOR >= 19
+ #include <cstdlib>
+ #if CLANG_VERSION_MAJOR >= 19| using namespace llvm; | ||
| using namespace clang; | ||
|
|
||
| TEST(ScopeReflectionTest, DemangleSymbol) { |
There was a problem hiding this comment.
warning: variable 'TEST' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
TEST(ScopeReflectionTest, DemangleSymbol) {
^
Vipul-Cariappa
force-pushed
the
dev/demangle
branch
from
9969e0b to
9b24c54
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
+ Coverage 70.96% 71.04% +0.07%
==========================================
Files 9 9
Lines 3541 3550 +9
==========================================
+ Hits 2513 2522 +9
Misses 1028 1028
|
Vipul-Cariappa
force-pushed
the
dev/demangle
branch
5 times, most recently
from
8bb8cbf to
e6ff45b
Compare
| #include "clang/AST/DeclBase.h" | ||
| #include "clang/AST/GlobalDecl.h" | ||
|
|
||
| #include "gtest/gtest.h" |
There was a problem hiding this comment.
warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]
#include "gtest/gtest.h"
^| using namespace clang; | ||
|
|
||
| TEST(ScopeReflectionTest, DemangleSymbol) { | ||
| if (llvm::sys::RunningOnValgrind()) |
There was a problem hiding this comment.
warning: no header providing "llvm::sys::RunningOnValgrind" is directly included [misc-include-cleaner]
unittests/CppInterOp/ScopeReflectionTest.cpp:14:
+ #include <llvm/Support/Valgrind.h>| if (llvm::sys::RunningOnValgrind()) | ||
| GTEST_SKIP() << "XFAIL due to Valgrind report"; | ||
|
|
||
| std::string code = R"( |
There was a problem hiding this comment.
warning: no header providing "std::string" is directly included [misc-include-cleaner]
unittests/CppInterOp/ScopeReflectionTest.cpp:14:
+ #include <string>|
|
||
| std::string mangled_add_int; | ||
| std::string mangled_add_double; | ||
| compat::maybeMangleDeclName(Add_int, mangled_add_int); |
There was a problem hiding this comment.
warning: no header providing "compat::maybeMangleDeclName" is directly included [misc-include-cleaner]
unittests/CppInterOp/ScopeReflectionTest.cpp:3:
- #include "clang-c/CXCppInterOp.h"
+ #include "/github/workspace/lib/Interpreter/Compatibility.h"
+ #include "clang-c/CXCppInterOp.h"
Vipul-Cariappa
force-pushed
the
dev/demangle
branch
from
e6ff45b to
67fef53
Compare
Vipul-Cariappa
changed the title
DemangleSymbol and IsClassPolymorphic APIsDemangle and IsClassPolymorphic APIs
Vipul-Cariappa
force-pushed
the
dev/demangle
branch
from
67fef53 to
a021250
Compare
2 participants
Description
Implements
DemangleSymbolandIsClassPolymorphicAPIs. These are needed to implementCppyy::GetActualClass.Fixes
Fixes 8 tests on cppyy, once
Cppyy::GetActualClassis implemented.Testing
Implemented necessary tests.
Checklist