[test] Use platform pointer size in type reflection test #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
=======================================
Coverage 70.96% 70.96%
=======================================
Files 9 9
Lines 3541 3541
=======================================
Hits 2513 2513
Misses 1028 1028 |
aaronj0
force-pushed
the
test-fix
branch
3 times, most recently
from
d5973ab to
c3dc950
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| #include <algorithm> | ||
| #include <cstdint> | ||
| #include <string> |
There was a problem hiding this comment.
warning: included header cstdint is not used directly [misc-include-cleaner]
Suggested change
| #include <string> | |
| #include <string> |
| #include "clang/Frontend/CompilerInstance.h" | ||
| #include "clang/Sema/Sema.h" | ||
|
|
||
| #include "gtest/gtest.h" |
There was a problem hiding this comment.
warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]
#include "gtest/gtest.h"
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an equality that is not consistent on win x86