These changes are super small. Let's try to put up bigger pull requests that change more things in a more uniform way. Eg. if we have 10 times to improve in the CI let's do them at once instead of generating 10 PRs.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.46%. Comparing base (a22df96) to head (04d8241).
Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
+ Coverage   75.33%   75.46%   +0.13%     
==========================================
  Files           9        9              
  Lines        3620     3628       +8     
==========================================
+ Hits         2727     2738      +11     
+ Misses        893      890       -3     

These changes are super small. Let's try to put up bigger pull requests that change more things in a more uniform way. Eg. if we have 10 times to improve in the CI let's do them at once instead of generating 10 PRs.

I will do this from now on (I have the very big change in the works to have reusable actions in the workflow to stop repetition). In most cases i'll have to just put the PR title and description as general ci improvements. The reason I put this llvm cache PR (and the other 2) as small incremental changes, was so that if anything went wrong it was obvious. as to what target change or in this case remove of the folder was responsible in case any test broke.

The reason I am trying to get small amounts from the cache size is that we are close to the 10GB limit, and currently we won't be able to get the llvm 20 PR in and stay under this limit (its going to be very close). If I cannot get us under this 10GB limit (I'm hoping to just scrape under it), do you have any preference as to what jobs get dropped from the ci? My suggestion would be the llvm 19 Windows job, since we aren't expecting full Windows support until at least llvm 20 I believe.

@vgvassilev can you please approve this PR? I've added a few improvements to the Emscripten ci as part this PR (detailed in the PR description). If you approve I will merge when activity is quiet in the repo, since it requires me to clear some builds in the Github cache.

Hi,

Mostly looks good. Just a question here and there (afk currently, shall type them out soon )

@anutosh491 if you approve, please leave it to me to merge this PR, since I need to clear some stuff from the cache first before merging, and it should be done when activity in the repo is quiet.

Actually I just realized that if we build with -DLLVM_BUILD_TOOLS=OFF, it only makes sense to also use CLANG_BUILD_TOOLS=OFF too isn't it ?

Actually I just realized that if we build with -DLLVM_BUILD_TOOLS=OFF, it only makes sense to also use CLANG_BUILD_TOOLS=OFF too isn't it ?

@anutosh491 I can do this additional change to the PR. Do you approve the PR subject to this change?