Add new overload for CreateInterpreter and deprecate old interface #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
vgvassilev
reviewed
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add a new overload for
CreateInterpreterthat takes astd::vector<std::string>(with an initializer_list overload as well) and makes the old interface deprecated (which accepted astd::vector<const char*>).Fixes #207
Type of change
Testing
Added unit tests in InterpreterTest.cpp that call the new overload (using both initializer lists and explicit std::vectorstd::string) to verify a valid interpreter is created.
Added a test for the deprecated interface (using std::vector<const char*>) to ensure backward compatibility (this usage triggers a compile-time deprecation warning).
Verified that the ambiguous calls are resolved and that all existing tests pass.
Checklist