Return pointer to non-const for getExecutionEngine #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `clang::Interpreter` wrapper previously returned a pointer to const, but the actual `clang::Interpreter` did not. This breaks code for anyone porting from `clang::Interpreter` to `Cpp::Interpreter`, especially since most operations on the execution engine are mutations of some sort. Yes, the user could static cast the wrapper to the inner interpreter, but, at that point, why both exposing the `getExecutionEngine` function at all?
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| const llvm::orc::LLJIT* getExecutionEngine() const { | ||
| llvm::orc::LLJIT* getExecutionEngine() const { |
Contributor
There was a problem hiding this comment.
warning: function 'getExecutionEngine' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| llvm::orc::LLJIT* getExecutionEngine() const { | |
| [[nodiscard]] llvm::orc::LLJIT* getExecutionEngine() const { |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
=======================================
Coverage 75.94% 75.94%
=======================================
Files 9 9
Lines 3646 3646
=======================================
Hits 2769 2769
Misses 877 877
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
clang::Interpreterwrapper previously returned a pointer to const, but the actualclang::Interpreterdid not. This breaks code for anyone porting fromclang::InterpretertoCpp::Interpreter, especially since most operations on the execution engine are mutations of some sort.Yes, the user could static cast the wrapper to the inner interpreter, but, at that point, why both exposing the
getExecutionEnginefunction at all?