From eb2fcdefd79be378d037bd85ad729e1a1b938702 Mon Sep 17 00:00:00 2001 From: mcbarton Date: Thu, 27 Nov 2025 20:49:45 +0000 Subject: [PATCH 1/3] Only run tests under Valgrind for specific ci jobs --- .github/actions/Build_and_Test_CppInterOp/action.yml | 2 +- .github/actions/Build_and_Test_cppyy/action.yml | 2 +- .github/workflows/main.yml | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/actions/Build_and_Test_CppInterOp/action.yml b/.github/actions/Build_and_Test_CppInterOp/action.yml index ba3372825..e58e3b298 100644 --- a/.github/actions/Build_and_Test_CppInterOp/action.yml +++ b/.github/actions/Build_and_Test_CppInterOp/action.yml @@ -58,7 +58,7 @@ runs: else cmake --build . --target check-cppinterop --parallel ${{ env.ncpus }} os="${{ matrix.os }}" - if [[ "${os}" != "macos"* ]]; then + if [[ "${os}" != "macos"* && "${matrix.Valgrind}" == "On" ]]; then CLANG_VERSION="${{ matrix.clang-runtime }}" if [[ "$CLANG_VERSION" == "20" && "${{ matrix.cling }}" == "Off" ]]; then SUPPRESSION_FILE="../etc/clang${CLANG_VERSION}-valgrind.supp" diff --git a/.github/actions/Build_and_Test_cppyy/action.yml b/.github/actions/Build_and_Test_cppyy/action.yml index 5cb73f36f..548d9b953 100644 --- a/.github/actions/Build_and_Test_cppyy/action.yml +++ b/.github/actions/Build_and_Test_cppyy/action.yml @@ -106,7 +106,7 @@ runs: set -o pipefail os="${{ matrix.os }}" - if [[ "${os}" != "macos"* ]]; then + if [[ "${os}" != "macos"* && "${matrix.Valgrind}" == "On" ]]; then echo "Running valgrind on passing tests" CLANG_VERSION="${{ matrix.clang-runtime }}" diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 8c308ca55..9db2b1d90 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -31,6 +31,7 @@ jobs: cppyy: Off llvm_enable_projects: "clang" llvm_targets_to_build: "host;NVPTX" + Valgrind: On - name: ubu24-arm-gcc12-clang-repl-19-cppyy os: ubuntu-24.04-arm compiler: gcc-12 @@ -67,6 +68,7 @@ jobs: llvm_targets_to_build: "host;NVPTX" coverage: true oop-jit: On + Valgrind: On - name: ubu24-x86-gcc12-clang-repl-20 os: ubuntu-24.04 compiler: gcc-12 @@ -311,3 +313,4 @@ jobs: uses: mxschmitt/action-tmate@v3 # When debugging increase to a suitable value! timeout-minutes: 30 + From 65e8f15d06390902fe8cb9393982051c78bc69db Mon Sep 17 00:00:00 2001 From: mcbarton Date: Thu, 27 Nov 2025 21:09:27 +0000 Subject: [PATCH 2/3] Fix conditional check for Valgrind in action.yml --- .github/actions/Build_and_Test_CppInterOp/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/Build_and_Test_CppInterOp/action.yml b/.github/actions/Build_and_Test_CppInterOp/action.yml index e58e3b298..873a6a5f9 100644 --- a/.github/actions/Build_and_Test_CppInterOp/action.yml +++ b/.github/actions/Build_and_Test_CppInterOp/action.yml @@ -58,7 +58,7 @@ runs: else cmake --build . --target check-cppinterop --parallel ${{ env.ncpus }} os="${{ matrix.os }}" - if [[ "${os}" != "macos"* && "${matrix.Valgrind}" == "On" ]]; then + if [[ "${os}" != "macos"* && "${{ matrix.Valgrind }}" == "On" ]]; then CLANG_VERSION="${{ matrix.clang-runtime }}" if [[ "$CLANG_VERSION" == "20" && "${{ matrix.cling }}" == "Off" ]]; then SUPPRESSION_FILE="../etc/clang${CLANG_VERSION}-valgrind.supp" From 0c1ba2e923f1f5734e1dffd29a73342a2728b98d Mon Sep 17 00:00:00 2001 From: mcbarton Date: Thu, 27 Nov 2025 21:09:46 +0000 Subject: [PATCH 3/3] Fix syntax for accessing matrix variable in action.yml --- .github/actions/Build_and_Test_cppyy/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/Build_and_Test_cppyy/action.yml b/.github/actions/Build_and_Test_cppyy/action.yml index 548d9b953..b4c890cfd 100644 --- a/.github/actions/Build_and_Test_cppyy/action.yml +++ b/.github/actions/Build_and_Test_cppyy/action.yml @@ -106,7 +106,7 @@ runs: set -o pipefail os="${{ matrix.os }}" - if [[ "${os}" != "macos"* && "${matrix.Valgrind}" == "On" ]]; then + if [[ "${os}" != "macos"* && "${{ matrix.Valgrind }}" == "On" ]]; then echo "Running valgrind on passing tests" CLANG_VERSION="${{ matrix.clang-runtime }}"