Skip to content

Commit fbe9888

Browse files
aaronj0vgvassilev
authored andcommitted
[ci] Update the CI to follow other repositories in running valgrind
This was never updated on the backend repo and lags the other repos. This should fix the current failures in the CI on master
1 parent 5406969 commit fbe9888

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -720,13 +720,10 @@ jobs:
720720
if [[ "${{ matrix.os }}" == macos-* ]]; then
721721
echo "Skipping Valgrind checks on macOS"
722722
else
723-
if [[ "${{ matrix.clang-runtime }}" == "17" ]]; then
724-
echo "Valgrind reports true for clang-runtime 17, due to memory leaks with LLVM"
725-
valgrind --show-error-list=yes --error-exitcode=1 --suppressions=../etc/valgrind-cppyy-cling.supp python -m pytest -m "not xfail" -v || true
726-
else
727-
echo "Running valgrind on passing tests"
728-
valgrind --show-error-list=yes --error-exitcode=1 --suppressions=../etc/valgrind-cppyy-cling.supp python -m pytest -m "not xfail" -v
729-
fi
723+
echo "Running valgrind on passing tests"
724+
CLANG_VERSION="${{ matrix.clang-runtime }}"
725+
SUPPRESSION_FILE="../etc/clang${CLANG_VERSION}-valgrind.supp"
726+
valgrind --show-error-list=yes --error-exitcode=1 --track-origins=yes --suppressions="${SUPPRESSION_FILE}" --suppressions=../etc/valgrind-cppyy-cling.supp python -m pytest -m "not xfail" -v
730727
fi
731728
export RETCODE=+$?
732729
echo ::endgroup::

0 commit comments

Comments
 (0)