Skip to content

Commit 4e34223

Browse files
authored
Speed up ci by removing running CppInterOp tests and Valgrind check CppInterOp (#82)
1 parent b1628f6 commit 4e34223

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -509,6 +509,7 @@ jobs:
509509
-DClang_DIR=$LLVM_BUILD_DIR/lib/cmake/clang \
510510
-DBUILD_SHARED_LIBS=ON \
511511
-DCMAKE_INSTALL_PREFIX=$CPPINTEROP_DIR \
512+
-DCPPINTEROP_ENABLE_TESTING=OFF \
512513
../
513514
else
514515
cmake -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} \
@@ -518,15 +519,12 @@ jobs:
518519
-DClang_DIR=$LLVM_BUILD_DIR/lib/cmake/clang \
519520
-DBUILD_SHARED_LIBS=ON \
520521
-DCMAKE_INSTALL_PREFIX=$CPPINTEROP_DIR \
522+
-DCPPINTEROP_ENABLE_TESTING=OFF \
521523
../
522524
fi
523525
os="${{ matrix.os }}"
524-
cmake --build . --target check-cppinterop --parallel ${{ env.ncpus }}
526+
cmake --build . --parallel ${{ env.ncpus }}
525527
cppyy_on=$(echo "${{ matrix.cppyy }}" | tr '[:lower:]' '[:upper:]')
526-
if [[ ("${cppyy_on}" != "ON") && ("${os}" == "ubuntu"*) ]]; then
527-
# TODO: Remove "|| true" when fix memory issues in LLVM/Clang 17
528-
valgrind --track-origins=yes --error-exitcode=1 unittests/CppInterOp/CppInterOpTests 2>&1 >/dev/null || true
529-
fi
530528
cd ../..
531529
# We need CB_PYTHON_DIR later
532530
echo "CB_PYTHON_DIR=$CB_PYTHON_DIR" >> $GITHUB_ENV
@@ -593,6 +591,7 @@ jobs:
593591
-DUSE_REPL=OFF `
594592
-DCling_DIR="$env:LLVM_BUILD_DIR\tools\cling" `
595593
-DLLVM_DIR="$env:LLVM_BUILD_DIR" `
594+
-DCPPINTEROP_ENABLE_TESTING=OFF `
596595
-DClang_DIR="$env:LLVM_BUILD_DIR" -DCMAKE_INSTALL_PREFIX="$env:CPPINTEROP_DIR" ..\
597596
}
598597
else
@@ -601,9 +600,10 @@ jobs:
601600
-DUSE_CLING=OFF `
602601
-DUSE_REPL=ON `
603602
-DLLVM_DIR="$env:LLVM_BUILD_DIR\lib\cmake\llvm" `
603+
-DCPPINTEROP_ENABLE_TESTING=OFF `
604604
-DClang_DIR="$env:LLVM_BUILD_DIR\lib\cmake\clang" -DCMAKE_INSTALL_PREFIX="$env:CPPINTEROP_DIR" ..\
605605
}
606-
cmake --build . --config ${{ env.BUILD_TYPE }} --target check-cppinterop --parallel ${{ env.ncpus }}
606+
cmake --build . --parallel ${{ env.ncpus }}
607607
cd ..\..
608608
609609
- name: Build and Install cppyy-backend on Unix Systems

0 commit comments

Comments
 (0)