Skip to content

Commit 79ea71b

Browse files
committed
Enable 2 xpass on Cling, and 1 on Clang-Repl
1 parent f8a303b commit 79ea71b

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

test/test_cpp11features.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ def test01_smart_ptr(self):
4444
gc.collect()
4545
assert TestSmartPtr.s_counter == 0
4646

47+
@mark.xfail(run = False, condition=IS_LINUX_ARM, reason="Valgrind issues")
4748
def test02_smart_ptr_construction(self):
4849
"""Shared/Unique pointer ctor is templated, requiring special care"""
4950

@@ -433,7 +434,7 @@ def test14_shared_ptr_passing(self):
433434
gc.collect()
434435
assert TestSmartPtr.s_counter == 0
435436

436-
@mark.xfail(condition=(IS_MAC and IS_CLING), reason = "Fails on OS X Cling")
437+
@mark.xfail(condition=IS_CLING, reason = "Fails on Cling")
437438
def test15_unique_ptr_template_deduction(self):
438439
"""Argument type deduction with std::unique_ptr"""
439440

test/test_templates.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def test04_variadic_function(self):
145145

146146
assert cppyy.gbl.test04_variadic_func['int', 'double', 'void*']() == 3
147147

148-
@mark.xfail(condition=IS_CLING, reason="Fails with Cling")
148+
@mark.xfail(condition=IS_MAC and IS_CLING, reason="Fails with OSX Cling")
149149
def test05_variadic_overload(self):
150150
"""Call an overloaded variadic function"""
151151

@@ -476,7 +476,7 @@ def test18_greedy_overloads(self):
476476
assert g3.get_size(ns.SomeClass()) == cppyy.sizeof(ns.SomeClass)
477477
assert g3.get_size(cppyy.nullptr, True) == -1
478478

479-
@mark.xfail(condition = (IS_MAC and IS_CLING), reason = "Fails on OS X Cling")
479+
@mark.xfail(condition = IS_CLING, reason = "Fails on Cling")
480480
def test19_templated_operator_add(self):
481481
"""Templated operator+ is ambiguous: either __pos__ or __add__"""
482482

@@ -587,7 +587,7 @@ def test23_overloaded_setitem(self):
587587
v = MyVec["float"](2)
588588
v[0] = 1 # used to throw TypeError
589589

590-
@mark.xfail(run=not IS_CLANG_REPL, reason="Crashes in ClangRepl")
590+
@mark.xfail(condition=IS_MAC, reason="Fails on OS X")
591591
def test24_stdfunction_templated_arguments(self):
592592
"""Use of std::function with templated arguments"""
593593

0 commit comments

Comments
 (0)