Skip to content

Commit 9be189a

Browse files
[test] update tags (#128)
Enable xfails that pass
1 parent 01be0e0 commit 9be189a

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

test/test_cpp11features.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,6 @@ def test09_lambda_calls(self):
337337
assert l3
338338
assert l3(2) == 48
339339

340-
@mark.xfail
341340
def test10_optional(self):
342341
"""Use of optional and nullopt"""
343342

test/test_crossinheritance.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -825,7 +825,7 @@ def z(self):
825825
assert a.m_2 == 42
826826
assert a.m_3 == 67
827827

828-
@mark.xfail(run=not IS_CLANG_DEBUG, reason="Crashes with ClangRepl with 'toString not implemented'")
828+
@mark.xfail(run=False, condition=IS_LINUX_ARM, reason="Crashes with Valgrind on Linux ARM, but passes in all platforms otherwise")
829829
def test21_multiple_inheritance_with_constructors(self):
830830
"""Multiple inheritance with constructors"""
831831

@@ -913,7 +913,7 @@ def z(self):
913913
assert a.m_2 == 88
914914
assert a.m_3 == -11
915915

916-
@mark.xfail(run=not IS_CLANG_DEBUG, reason="Crashes with ClangRepl with 'toString not implemented'")
916+
@mark.xfail(run=False, condition=IS_LINUX_ARM, reason="Crashes with Valgrind on Linux ARM, but passes in all platforms otherwise")
917917
def test22_multiple_inheritance_with_defaults(self):
918918
"""Multiple inheritance with defaults"""
919919

@@ -1285,7 +1285,7 @@ class D(B):
12851285
assert inst.fun1() == val1
12861286
assert inst.fun2() == inst.fun1()
12871287

1288-
@mark.xfail(run=not IS_CLANG_DEBUG, reason="Crashes with ClangRepl with 'toString not implemented'")
1288+
@mark.xfail(run=False, condition=IS_LINUX_ARM, reason="Crashes with Valgrind on Linux ARM, but passes in all platforms otherwise")
12891289
def test29_cross_deep_multi(self):
12901290
"""Deep multi-inheritance hierarchy"""
12911291

@@ -1527,7 +1527,7 @@ def getValue(self):
15271527
gc.collect()
15281528
assert ns.Component.get_count() == 0
15291529

1530-
@mark.xfail(run=not IS_CLANG_DEBUG, reason="Crashes with ClangRepl with 'toString not implemented'")
1530+
@mark.xfail(run=False, condition=IS_LINUX_ARM, reason="Crashes with Valgrind on Linux ARM, but passes in all platforms otherwise")
15311531
def test32_by_value_arguments(self):
15321532
"""Override base function taking by-value arguments"""
15331533

test/test_regression.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1015,7 +1015,7 @@ def test34_print_empty_collection(self):
10151015
v = cppyy.gbl.std.vector[int]()
10161016
str(v)
10171017

1018-
@mark.xfail(run=IS_CLANG_REPL, reason="Crashes on Cling")
1018+
@mark.xfail(run=IS_CLANG_REPL, condition=IS_MAC or not IS_CLANG_REPL, reason="Crashes on Cling")
10191019
def test35_filesytem(self):
10201020
"""Static path object used to crash on destruction"""
10211021

0 commit comments

Comments
 (0)