Skip to content

Commit 01561bd

Browse files
committed
Redistribute parts of actions for speed and stop repetition
1 parent bc255e0 commit 01561bd

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

.github/actions/Emscripten-Notebook-Tests/action.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ runs:
1919
run: |
2020
set -e
2121
micromamba activate xeus-lite-host
22+
export INPUT_TEXT=""
2223
if [[ "${{ inputs.notebook }}" == "xeus-cpp-lite-demo.ipynb"* ]]; then
2324
export INPUT_TEXT="--stdin Test_Name"
2425
fi
@@ -35,8 +36,6 @@ runs:
3536
export SAFARI_TESTS_RETURN_VALUE=0
3637
touch safari_diff.txt
3738
if [[ "${{ matrix.os }}" == "macos"* ]]; then
38-
python -m pip install PyAutoGUI
39-
python scripts/enable-downloads-safari-github-ci.py
4039
echo "Running xeus-cpp in Jupter Lite in Safari"
4140
python -u scripts/automated-notebook-run-script.py --driver safari --notebook ${{ inputs.notebook }} --kernel ${{ inputs.kernel }} $INPUT_TEXT
4241
nbdiff notebooks/${{ inputs.notebook }} $HOME/Downloads/${{ inputs.notebook }} --ignore-id --ignore-metadata >> safari_diff.txt

.github/actions/Jupyter-serve/action.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ runs:
1414
brew install coreutils
1515
export PATH="$HOMEBREW_PREFIX/opt/coreutils/libexec/gnubin:$PATH"
1616
fi
17-
export INPUT_TEXT=""
1817
timeout 1080 jupyter lite serve --settings-overrides=overrides.json --XeusAddon.prefix=${{ env.PREFIX }} \
1918
--XeusAddon.mounts="${{ env.PREFIX }}/share/xeus-cpp/tagfiles:/share/xeus-cpp/tagfiles" \
2019
--XeusAddon.mounts="${{ env.PREFIX }}/etc/xeus-cpp/tags.d:/etc/xeus-cpp/tags.d" \
@@ -27,7 +26,12 @@ runs:
2726
# but there is no diff with the options chosen below (the latest doesn't show a diff, just the filenames with +++
2827
# and --- as if it was planning to show a diff. This only happens for xeus-cpp-lite-demo.ipynb.
2928
python -m pip install nbdime==3.2.0
30-
python -m pip install selenium
29+
if [[ "${{ matrix.os }}" == "macos"* ]]; then
30+
python -m pip install PyAutoGUI
31+
python scripts/enable-downloads-safari-github-ci.py
32+
else
33+
python -m pip install selenium
34+
fi
3135
# This sleep is to force enough time for the jupyter site to build before trying
3236
# to run notebooks in it. If you try to run the notebooks before the website is
3337
# ready the ci python script will crash saying ti cannot access the url

0 commit comments

Comments
 (0)