Update constructor for wasm interpreter

Author: anutosh491

include/xeus-cpp/xinterpreter_wasm.hpp

@@ -19,8 +19,7 @@ namespace xcpp
     {
     public:
 
-        wasm_interpreter();
-        wasm_interpreter(int argc, char** argv);
+        wasm_interpreter(const std::vector<std::string>& args);
         virtual ~wasm_interpreter() = default;
 
     };

include/xeus-cpp/xutils.hpp

@@ -32,6 +32,9 @@ namespace xcpp
 
     XEUS_CPP_API
     std::string retrieve_tagfile_dir();
+
+    XEUS_CPP_API
+    std::pair<int, char**> convert_to_argv(const std::vector<std::string>& args);
 }
 
 #endif

src/xinterpreter_wasm.cpp

@@ -12,17 +12,11 @@
 
 #include "xeus-cpp/xinterpreter.hpp"
 #include "xeus-cpp/xinterpreter_wasm.hpp"
+#include "xeus-cpp/xutils.hpp"
 
 namespace xcpp
 {
-
-    wasm_interpreter::wasm_interpreter()
-        : interpreter(0, nullptr)
-    {
-    }
-
-    wasm_interpreter::wasm_interpreter(int argc, char** argv)
-        : interpreter(argc, argv)
-    {
-    }
+    wasm_interpreter::wasm_interpreter(const std::vector<std::string>& args)
+        : interpreter(convert_to_argv(args).first, convert_to_argv(args).second)
+    {}
 }

src/xutils.cpp

@@ -102,4 +102,21 @@ namespace xcpp
 
         return prefix + "share" + separator + "xeus-cpp" + separator + "tagfiles";
     }
+
+    std::pair<int, char**> convert_to_argv(const std::vector<std::string>& args)
+    {
+        static std::vector<std::string> persistent_args = args;
+        static std::vector<const char*> argv_vec;
+
+        argv_vec.clear();
+        for (const auto& s : persistent_args)
+        {
+            argv_vec.push_back(s.c_str());
+        }
+
+        return {
+            static_cast<int>(argv_vec.size()),
+            const_cast<char**>(argv_vec.data())
+        };
+    }
 }