Switch to a shared xeus for the emscripten build (#334)

* Switch to a shared xeus for the emscripten build

* Add libxeus.so to the test directory

* add libxeus.so to kernelspec

* Update CMakeLists.txt

Author: anutosh491

CMakeLists.txt

@@ -54,8 +54,8 @@ option(XEUS_CPP_BUILD_STATIC "Build xeus-cpp static library" ON)
 option(XEUS_CPP_BUILD_SHARED "Split xcpp build into executable and library" ON)
 option(XEUS_CPP_BUILD_EXECUTABLE "Build the xcpp executable" ON)
 
-option(XEUS_CPP_USE_SHARED_XEUS "Link xcpp  with the xeus shared library (instead of the static library)" ON)
-option(XEUS_CPP_USE_SHARED_XEUS_CPP "Link xcpp  with the xeus shared library (instead of the static library)" ON)
+option(XEUS_CPP_USE_SHARED_XEUS "Link xcpp with the xeus shared library (instead of the static library)" ON)
+option(XEUS_CPP_USE_SHARED_XEUS_CPP "Link xcpp with the xeus-cpp shared library (instead of the static library)" ON)
 option(XEUS_CPP_EMSCRIPTEN_WASM_BUILD "Build for wasm with emscripten" OFF)
 
 # Test options
@@ -77,10 +77,11 @@ endif()
 if(EMSCRIPTEN)
     add_compile_definitions(XEUS_CPP_EMSCRIPTEN_WASM_BUILD)
     message("Build with emscripten")
+    set_property(GLOBAL PROPERTY TARGET_SUPPORTS_SHARED_LIBS TRUE)
     set(XEUS_CPP_BUILD_STATIC ON)
     set(XEUS_CPP_BUILD_SHARED OFF)
     set(XEUS_CPP_BUILD_EXECUTABLE OFF)
-    set(XEUS_CPP_USE_SHARED_XEUS OFF)
+    set(XEUS_CPP_USE_SHARED_XEUS ON)
     set(XEUS_CPP_USE_SHARED_XEUS_CPP OFF)
     # ENV (https://github.com/emscripten-core/emscripten/commit/6d9681ad04f60b41ef6345ab06c29bbc9eeb84e0)
     set(EMSCRIPTEN_FEATURES "${EMSCRIPTEN_FEATURES} -s \"EXPORTED_RUNTIME_METHODS=[ENV']\"")
@@ -546,4 +547,4 @@ if(EMSCRIPTEN)
             "$<TARGET_FILE_DIR:xcpp>/xcpp.wasm"
             "$<TARGET_FILE_DIR:xcpp>/xcpp.data"
             DESTINATION ${CMAKE_INSTALL_BINDIR})
-endif ()
+endif ()

share/jupyter/kernels/xcpp17/wasm_kernel.json.in

@@ -10,6 +10,7 @@
   "metadata": {
     "debugger": false,
     "shared": {
+      "libxeus.so": "lib/libxeus.so",
       "libclangCppInterOp.so": "lib/libclangCppInterOp.so"
     }
   }

share/jupyter/kernels/xcpp20/wasm_kernel.json.in

@@ -10,6 +10,7 @@
   "metadata": {
     "debugger": false,
     "shared": {
+      "libxeus.so": "lib/libxeus.so",
       "libclangCppInterOp.so": "lib/libclangCppInterOp.so"
     }
   }

share/jupyter/kernels/xcpp23/wasm_kernel.json.in

@@ -10,6 +10,7 @@
   "metadata": {
     "debugger": false,
     "shared": {
+      "libxeus.so": "lib/libxeus.so",
       "libclangCppInterOp.so": "lib/libclangCppInterOp.so"
     }
   }

test/CMakeLists.txt

@@ -90,6 +90,13 @@ if(EMSCRIPTEN)
         ${CMAKE_CURRENT_BINARY_DIR}/libclangCppInterOp.so
         COMMENT "Copying libclangCppInterOp.so to the test directory"
     )
+
+    add_custom_command(TARGET test_xeus_cpp POST_BUILD
+        COMMAND ${CMAKE_COMMAND} -E copy
+        ${CMAKE_INSTALL_PREFIX}/lib/libxeus.so
+        ${CMAKE_CURRENT_BINARY_DIR}/libxeus.so
+        COMMENT "Copying libxeus.so to the test directory"
+    )
 else()
     find_package(Threads)