Skip to content

Commit 5df440b

Browse files
committed
Run tinyraytracer notebook as part of ci
1 parent 3365b46 commit 5df440b

File tree

3 files changed

+42
-9
lines changed

3 files changed

+42
-9
lines changed

.github/workflows/deploy-github-page.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,27 @@ jobs:
163163
kernel: "C++23"
164164
timeout-minutes: 5
165165

166+
- name: Test C++17 kernel in tinyraytracer.ipynb
167+
uses: ./.github/actions/Emscripten-Notebook-Tests
168+
with:
169+
notebook: "tinyraytracer.ipynb"
170+
kernel: "C++17"
171+
timeout-minutes: 5
172+
173+
- name: Test C++20 kernel in tinyraytracer.ipynb
174+
uses: ./.github/actions/Emscripten-Notebook-Tests
175+
with:
176+
notebook: "tinyraytracer.ipynb"
177+
kernel: "C++20"
178+
timeout-minutes: 5
179+
180+
- name: Test C++23 kernel in tinyraytracer.ipynb
181+
uses: ./.github/actions/Emscripten-Notebook-Tests
182+
with:
183+
notebook: "tinyraytracer.ipynb"
184+
kernel: "C++23"
185+
timeout-minutes: 5
186+
166187
- name: Upload artifact
167188
uses: actions/upload-pages-artifact@v3
168189
with:

.github/workflows/main.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -353,6 +353,27 @@ jobs:
353353
kernel: "C++23"
354354
timeout-minutes: 5
355355

356+
- name: Test C++17 kernel in tinyraytracer.ipynb
357+
uses: ./.github/actions/Emscripten-Notebook-Tests
358+
with:
359+
notebook: "tinyraytracer.ipynb"
360+
kernel: "C++17"
361+
timeout-minutes: 5
362+
363+
- name: Test C++20 kernel in tinyraytracer.ipynb
364+
uses: ./.github/actions/Emscripten-Notebook-Tests
365+
with:
366+
notebook: "tinyraytracer.ipynb"
367+
kernel: "C++20"
368+
timeout-minutes: 5
369+
370+
- name: Test C++23 kernel in tinyraytracer.ipynb
371+
uses: ./.github/actions/Emscripten-Notebook-Tests
372+
with:
373+
notebook: "tinyraytracer.ipynb"
374+
kernel: "C++23"
375+
timeout-minutes: 5
376+
356377
- name: Setup tmate session
357378
if: ${{ failure() && runner.debug }}
358379
uses: mxschmitt/action-tmate@v3

scripts/automated-notebook-run-script.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -289,15 +289,6 @@ def main():
289289

290290
# Select Kernel based on input
291291
choose_kernel(driver, args)
292-
293-
# For reasons I don't understand sometimes
294-
# in the ci the notebook doesn't always start at the
295-
# first cell in Safari, which causes random failures
296-
# 9 UPs is random choice, and mostly chosen
297-
# to be largely enough that guaranteed to be at
298-
# start of notebook.
299-
if args.driver == "safari":
300-
ActionChains(driver).send_keys(Keys.ESCAPE).pause(0.01).send_keys(Keys.UP * 9)
301292

302293
# This will run all the cells of the chosen notebook
303294
run_notebook(driver, notebook_area, args)

0 commit comments

Comments
 (0)