Skip to content

Commit e2ef171

Browse files
authored
Remove using is_wasm and reduce links of configure_kernel further
1 parent 77a5ae9 commit e2ef171

File tree

1 file changed

+18
-30
lines changed

1 file changed

+18
-30
lines changed

CMakeLists.txt

Lines changed: 18 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -120,31 +120,25 @@ if (NOT DEFINED XEUS_CPP_KERNELSPEC_PATH)
120120
set(XEUS_CPP_KERNELSPEC_PATH "${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_BINDIR}/")
121121
endif ()
122122

123-
function(configure_kernel kernel is_wasm)
124-
if(NOT is_wasm)
123+
function(configure_kernel kernel)
124+
if (WIN32)
125+
string(REPLACE "\\" "/" kernel "${kernel}")
126+
string(REPLACE "\\" "/" XEUS_CPP_PATH "${XEUS_CPP_PATH}")
127+
string(REPLACE "\\" "/" XEUS_CPP_LD_LIBRARY_PATH "${XEUS_CPP_LD_LIBRARY_PATH}")
128+
string(REPLACE "\\" "/" XEUS_CPP_RESOURCE_DIR "${XEUS_CPP_RESOURCE_DIR}")
129+
string(REPLACE "\\" "/" XEUS_CPP_INCLUDE_DIR "${XEUS_CPP_INCLUDE_DIR}")
130+
endif()
131+
if(NOT EMSCRIPTEN)
132+
set(prefix "wasm")
133+
else()
125134
set(XEUS_CPP_PATH "$ENV{PATH}")
126135
set(XEUS_CPP_LD_LIBRARY_PATH "$ENV{LD_LIBRARY_PATH}")
127136
set(XEUS_CPP_INCLUDE_DIR ${CMAKE_INSTALL_PREFIX}/include)
128-
129-
if (WIN32)
130-
string(REPLACE "\\" "/" kernel "${kernel}")
131-
string(REPLACE "\\" "/" XEUS_CPP_PATH "${XEUS_CPP_PATH}")
132-
string(REPLACE "\\" "/" XEUS_CPP_LD_LIBRARY_PATH "${XEUS_CPP_LD_LIBRARY_PATH}")
133-
string(REPLACE "\\" "/" XEUS_CPP_RESOURCE_DIR "${XEUS_CPP_RESOURCE_DIR}")
134-
string(REPLACE "\\" "/" XEUS_CPP_INCLUDE_DIR "${XEUS_CPP_INCLUDE_DIR}")
135-
endif()
136-
137-
configure_file(
138-
"${CMAKE_CURRENT_SOURCE_DIR}${kernel}kernel.json.in"
139-
"${CMAKE_CURRENT_BINARY_DIR}${kernel}kernel.json"
140-
)
141-
else()
142-
configure_file(
143-
"${CMAKE_CURRENT_SOURCE_DIR}${kernel}wasm_kernel.json.in"
144-
"${CMAKE_CURRENT_BINARY_DIR}${kernel}kernel.json"
145-
)
146137
endif()
147-
138+
configure_file(
139+
"${CMAKE_CURRENT_SOURCE_DIR}${prefix}${kernel}${prefix}_kernel.json.in"
140+
"${CMAKE_CURRENT_BINARY_DIR}${kernel}kernel.json"
141+
)
148142
configure_file(
149143
"${CMAKE_CURRENT_SOURCE_DIR}${kernel}logo-32x32.png"
150144
"${CMAKE_CURRENT_BINARY_DIR}${kernel}"
@@ -163,15 +157,9 @@ function(configure_kernel kernel is_wasm)
163157
endfunction()
164158

165159
message("Configure kernels: ...")
166-
if(EMSCRIPTEN)
167-
configure_kernel("/share/jupyter/kernels/xcpp17/" TRUE)
168-
configure_kernel("/share/jupyter/kernels/xcpp20/" TRUE)
169-
configure_kernel("/share/jupyter/kernels/xcpp23/" TRUE)
170-
else()
171-
configure_kernel("/share/jupyter/kernels/xcpp17/" FALSE)
172-
configure_kernel("/share/jupyter/kernels/xcpp20/" FALSE)
173-
configure_kernel("/share/jupyter/kernels/xcpp23/" FALSE)
174-
endif()
160+
configure_kernel("/share/jupyter/kernels/xcpp17/")
161+
configure_kernel("/share/jupyter/kernels/xcpp20/")
162+
configure_kernel("/share/jupyter/kernels/xcpp23/")
175163

176164
# Source files
177165
# ============

0 commit comments

Comments
 (0)