-
Notifications
You must be signed in to change notification settings - Fork 36
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Currently while building xeus-cpp-lite I see
-- Install configuration: "Release"
-- Up-to-date: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/xeus-cpp/tagfiles
-- Up-to-date: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/xeus-cpp/tagfiles/cppreference-doxygen-web.tag
-- Up-to-date: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/etc/xeus-cpp/tags.d
-- Up-to-date: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/etc/xeus-cpp/tags.d/stl.json
-- Up-to-date: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/jupyter/kernels
-- Up-to-date: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/jupyter/kernels/xcpp20
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/jupyter/kernels/xcpp20/kernel.json
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/jupyter/kernels/xcpp20/logo-64x64.png
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/jupyter/kernels/xcpp20/logo-32x32.png
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/share/jupyter/kernels/xcpp20/logo-svg.svg
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/lib/cmake/xeus-cpp/xeus-cppConfig.cmake
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/lib/cmake/xeus-cpp/xeus-cppConfigVersion.cmake
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/bin/xcpp.js
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/bin/xcpp.wasm
-- Installing: /Users/anutosh491/micromamba/envs/xeus-cpp-wasm-host/bin/xcpp.data
If you see, the .tag and the .d files also end up in the prefix just like the native case.
But the point is that jupyterlite-xeus only takes care of the kernels dir, the xx.cmake files and the xx.js, xx.wasm, xx.data files. It won't be handling the tagfiles.
Rather for the inspect request to work, these files are taken care of here.
Lines 449 to 450 in b6a7267
| PUBLIC "SHELL: --preload-file ${XEUS_CPP_DATA_DIR}@/share/xeus-cpp" | |
| PUBLIC "SHELL: --preload-file ${XEUS_CPP_CONF_DIR}@/etc/xeus-cpp" |
Hence technically these files being installed are redundant for the lite case. No need to install them while building xeus-cpp-lite.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working