From 627456ad635edef4bf50c5dee209c927eb767254 Mon Sep 17 00:00:00 2001 From: mcbarton <150042563+mcbarton@users.noreply.github.com> Date: Fri, 29 Nov 2024 15:42:07 +0000 Subject: [PATCH 1/2] Update clang-tidy-review action to v0.20.1 --- .github/workflows/clang-tidy-review-post.yml | 2 +- .github/workflows/clang-tidy-review.yml | 4 ++-- src/xoptions.cpp | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/clang-tidy-review-post.yml b/.github/workflows/clang-tidy-review-post.yml index 8916679c..4c76abd4 100644 --- a/.github/workflows/clang-tidy-review-post.yml +++ b/.github/workflows/clang-tidy-review-post.yml @@ -21,7 +21,7 @@ jobs: steps: - name: Post review comments id: post-review - uses: ZedThree/clang-tidy-review/post@v0.18.0 + uses: ZedThree/clang-tidy-review/post@v0.20.1 with: max_comments: 10 diff --git a/.github/workflows/clang-tidy-review.yml b/.github/workflows/clang-tidy-review.yml index e7182089..6abce450 100644 --- a/.github/workflows/clang-tidy-review.yml +++ b/.github/workflows/clang-tidy-review.yml @@ -30,7 +30,7 @@ jobs: version: "17.0.6" - name: Run clang-tidy - uses: ZedThree/clang-tidy-review@v0.18.0 + uses: ZedThree/clang-tidy-review@v0.20.1 id: review with: build_dir: build @@ -53,4 +53,4 @@ jobs: cmake . -B build -DCMAKE_C_COMPILER="$GITHUB_WORKSPACE/llvm/bin/clang" -DCMAKE_CXX_COMPILER="$GITHUB_WORKSPACE/llvm/bin/clang++" -DCMAKE_EXPORT_COMPILE_COMMANDS=On - name: Upload artifacts - uses: ZedThree/clang-tidy-review/upload@v0.18.0 + uses: ZedThree/clang-tidy-review/upload@v0.20.1 diff --git a/src/xoptions.cpp b/src/xoptions.cpp index ba277f35..af8ba331 100644 --- a/src/xoptions.cpp +++ b/src/xoptions.cpp @@ -44,3 +44,4 @@ namespace xcpp } } } + From 5d6dda3270f9001a8ffdf4d6bb51e0969fcd6eae Mon Sep 17 00:00:00 2001 From: mcbarton <150042563+mcbarton@users.noreply.github.com> Date: Fri, 29 Nov 2024 15:55:37 +0000 Subject: [PATCH 2/2] Fix clang format now new clang tidy review workflow is known to work --- src/xoptions.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/xoptions.cpp b/src/xoptions.cpp index af8ba331..ba277f35 100644 --- a/src/xoptions.cpp +++ b/src/xoptions.cpp @@ -44,4 +44,3 @@ namespace xcpp } } } -