From db2d3d12d1304dbafba895eda6e77bd2cfbdbba9 Mon Sep 17 00:00:00 2001 From: mcbarton Date: Fri, 6 Jun 2025 16:45:08 +0100 Subject: [PATCH 1/2] Set minimum required xeus-lite version to 3.2.1 --- CMakeLists.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 2fadd60b..0b4eea34 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -92,6 +92,10 @@ set(xeus_REQUIRED_VERSION 5.0.0) set(xeus_zmq_REQUIRED_VERSION 3.0.0) set(CppInterOp_REQUIRED_VERSION 1.7.0) +if(EMSCRIPTEN) + set(xeus_lite_REQUIRED_VERSION 3.2.1) +endif() + if (NOT TARGET xeus AND NOT TARGET xeus-static) find_package(xeus ${xeus_REQUIRED_VERSION} REQUIRED) if (xeus_FOUND) @@ -439,7 +443,7 @@ if(EMSCRIPTEN) message(FATAL_ERROR "Failed to run 'embuilder build sdl2'") endif() include(WasmBuildOptions) - find_package(xeus-lite REQUIRED) + find_package(xeus-lite ${xeus_lite_REQUIRED_VERSION} REQUIRED) add_executable(xcpp src/main_emscripten_kernel.cpp ) target_link_libraries(xcpp PRIVATE xeus-lite) xeus_cpp_set_kernel_options(xcpp) From 7a9fc12c91660a1dd5608b681bc225e9133b58e4 Mon Sep 17 00:00:00 2001 From: mcbarton Date: Fri, 6 Jun 2025 17:23:01 +0100 Subject: [PATCH 2/2] Apply PR suggestion --- CMakeLists.txt | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 0b4eea34..15f010ee 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -91,10 +91,7 @@ endif() set(xeus_REQUIRED_VERSION 5.0.0) set(xeus_zmq_REQUIRED_VERSION 3.0.0) set(CppInterOp_REQUIRED_VERSION 1.7.0) - -if(EMSCRIPTEN) - set(xeus_lite_REQUIRED_VERSION 3.2.1) -endif() +set(xeus_lite_REQUIRED_VERSION 3.2.1) if (NOT TARGET xeus AND NOT TARGET xeus-static) find_package(xeus ${xeus_REQUIRED_VERSION} REQUIRED)