Revert https://github.com/compiler-research/xeus-cpp/pull/349 (keeping test) #350
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
+ Coverage 81.81% 82.10% +0.28%
==========================================
Files 20 20
Lines 957 950 -7
Branches 89 87 -2
==========================================
- Hits 783 780 -3
+ Misses 174 170 -4
... and 1 file with indirect coverage changes
🚀 New features to boost your workflow:
|
|
Hi, please wait before taking this in. The solution proposed by the Pr I made shouldn't be fundamentally wrong. There might be something deeper here. We should make a note of what creates the difference if there is one. Edit: also would be great if could you paste the exact line in the CI where the test fails ? I haven't seen the doctest failure if there's a test failing. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Okay as we need the jupyterlite deployment to work perfectly (as we're nearing the submission of the blog, I need the build and deploy CI to run)
Hence let's go ahead with this and debug whatever later.
Though we need to keep track of the improvements here and use the configure_request_impl through xeus https://xeus.readthedocs.io/en/latest/kernel_implementation.html#configurationa
for any operation before the first execute request .
3 participants
Description
Please include a summary of changes, motivation and context for this PR.
Fixes # (issue)
Currently CppInterOps Emscripten ci is broken to #349 for MacOS arm for llvm, as can be seen here https://github.com/compiler-research/CppInterOp/actions/runs/15633230695 .
The test itself passes in these circumstances with the old get_stdopt as can be seen here compiler-research/CppInterOp#632 . Therefore this PR suggests reverting get_stdopt while keeping the test
Type of change
Please tick all options which are relevant.