Skip to content

Commit 8a6deb2

Browse files
author
Chris Vermeulen
authored
Ensure evidence backmatter functions correctly (#264)
* Ensure evidence backmatter functions correctly * Update docs
1 parent a214e30 commit 8a6deb2

File tree

4 files changed

+14
-7
lines changed

4 files changed

+14
-7
lines changed

docs/docs.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15247,7 +15247,7 @@ const docTemplate = `{
1524715247
"$ref": "#/definitions/handler.EvidenceActivity"
1524815248
}
1524915249
},
15250-
"backMatter": {
15250+
"back-matter": {
1525115251
"$ref": "#/definitions/oscalTypes_1_1_3.BackMatter"
1525215252
},
1525315253
"components": {
@@ -16758,7 +16758,7 @@ const docTemplate = `{
1675816758
}
1675916759
},
1676016760
"back-matter": {
16761-
"$ref": "#/definitions/relational.BackMatter"
16761+
"$ref": "#/definitions/oscalTypes_1_1_3.BackMatter"
1676216762
},
1676316763
"components": {
1676416764
"type": "array",

docs/swagger.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15241,7 +15241,7 @@
1524115241
"$ref": "#/definitions/handler.EvidenceActivity"
1524215242
}
1524315243
},
15244-
"backMatter": {
15244+
"back-matter": {
1524515245
"$ref": "#/definitions/oscalTypes_1_1_3.BackMatter"
1524615246
},
1524715247
"components": {
@@ -16752,7 +16752,7 @@
1675216752
}
1675316753
},
1675416754
"back-matter": {
16755-
"$ref": "#/definitions/relational.BackMatter"
16755+
"$ref": "#/definitions/oscalTypes_1_1_3.BackMatter"
1675616756
},
1675716757
"components": {
1675816758
"type": "array",

docs/swagger.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ definitions:
143143
items:
144144
$ref: '#/definitions/handler.EvidenceActivity'
145145
type: array
146-
backMatter:
146+
back-matter:
147147
$ref: '#/definitions/oscalTypes_1_1_3.BackMatter'
148148
components:
149149
description: Which components of the subject are being observed. A tool, user,
@@ -1083,7 +1083,7 @@ definitions:
10831083
$ref: '#/definitions/oscalTypes_1_1_3.Activity'
10841084
type: array
10851085
back-matter:
1086-
$ref: '#/definitions/relational.BackMatter'
1086+
$ref: '#/definitions/oscalTypes_1_1_3.BackMatter'
10871087
components:
10881088
items:
10891089
$ref: '#/definitions/oscalTypes_1_1_3.SystemComponent'

internal/api/handler/evidence.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ type EvidenceCreateRequest struct {
142142

143143
Props []oscalTypes_1_1_3.Property
144144
Links []oscalTypes_1_1_3.Link
145-
BackMatter *oscalTypes_1_1_3.BackMatter
145+
BackMatter *oscalTypes_1_1_3.BackMatter `json:"back-matter,omitempty"`
146146

147147
// Who or What is generating this evidence
148148
Origins []oscalTypes_1_1_3.Origin
@@ -398,6 +398,7 @@ func (h *EvidenceHandler) Search(ctx echo.Context) error {
398398

399399
type OscalLikeEvidence struct {
400400
relational.Evidence
401+
BackMatter *oscalTypes_1_1_3.BackMatter `json:"back-matter,omitempty"`
401402
Props []oscalTypes_1_1_3.Property `json:"props"`
402403
Links []oscalTypes_1_1_3.Link `json:"links"`
403404
Origins []oscalTypes_1_1_3.Origin `json:"origins,omitempty"`
@@ -439,6 +440,10 @@ func (o *OscalLikeEvidence) FromEvidence(evidence *relational.Evidence) error {
439440
}
440441
return out
441442
}()
443+
o.BackMatter = &oscalTypes_1_1_3.BackMatter{}
444+
if evidence.BackMatter != nil {
445+
o.BackMatter = evidence.BackMatter.MarshalOscal()
446+
}
442447
o.Status = evidence.Status.Data()
443448
return nil
444449
}
@@ -465,6 +470,8 @@ func (h *EvidenceHandler) Get(ctx echo.Context) error {
465470
var evidence relational.Evidence
466471
if err := h.db.
467472
Preload("Labels").
473+
Preload("BackMatter").
474+
Preload("BackMatter.Resources").
468475
Preload("Activities").
469476
Preload("Activities.Steps").
470477
Preload("InventoryItems").

0 commit comments

Comments
 (0)