properly support append mode with the vFile:open packet

andrurogerz · compnerd · commit 67e77f192d52 · 2024-10-03T08:29:10.000-07:00
30b6a55 missed adding support for append mode in `vFile:open`
diff --git a/Sources/GDBRemote/Session.cpp b/Sources/GDBRemote/Session.cpp
@@ -273,6 +273,9 @@ OpenFlags Session::ConvertOpenFlags(uint32_t protocolFlags) {
     return kOpenFlagInvalid; // Invalid mode
   }
 
+  if (protocolFlags & 0x8)
+    flags |= kOpenFlagAppend;
+
   flags = flags
     | (protocolFlags & 0x200 ? kOpenFlagCreate : 0) // eOpenOptionCanCreate (O_CREAT)
     | (protocolFlags & 0x400 ? kOpenFlagTruncate : 0) // eOpenOptionTruncate (O_TRUNC)

Original file line number	Diff line number	Diff line change
`@@ -273,6 +273,9 @@ OpenFlags Session::ConvertOpenFlags(uint32_t protocolFlags) {`
`273`	`273`	`return kOpenFlagInvalid; // Invalid mode`
`274`	`274`	`}`
`275`	`275`
	`276`	`+ if (protocolFlags & 0x8)`
	`277`	`+ flags \|= kOpenFlagAppend;`
	`278`	`+`
`276`	`279`	`flags = flags`
`277`	`280`	`\| (protocolFlags & 0x200 ? kOpenFlagCreate : 0) // eOpenOptionCanCreate (O_CREAT)`
`278`	`281`	`\| (protocolFlags & 0x400 ? kOpenFlagTruncate : 0) // eOpenOptionTruncate (O_TRUNC)`