Skip to content

Commit 93373a9

Browse files
Fix android sdk brotli build break (#1047)
* Pass Android versions of Brotli libraries * Pass triple and not module triple --------- Co-authored-by: Leonard Grey <[email protected]>
1 parent 64c350a commit 93373a9

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

.github/actions/configure-cmake-project/action.yml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -299,11 +299,7 @@ runs:
299299
}
300300
301301
Add-KeyValueIfNew $Defines CMAKE_Swift_COMPILER $SWIFTC
302-
303-
$TargetInfo = & $SWIFTC -target $Triple -print-target-info
304-
$TargetInfo = $TargetInfo | ConvertFrom-Json
305-
$TargetInfo = $TargetInfo.target.moduleTriple
306-
Add-KeyValueIfNew $Defines CMAKE_Swift_COMPILER_TARGET $TargetInfo
302+
Add-KeyValueIfNew $Defines CMAKE_Swift_COMPILER_TARGET $Triple
307303
308304
# TODO(compnerd): remove this once we have the early swift-driver
309305
Add-KeyValueIfNew $Defines CMAKE_Swift_COMPILER_USE_OLD_DRIVER "YES"
@@ -418,11 +414,7 @@ runs:
418414
"swiftc.exe"
419415
}
420416
Add-KeyValueIfNew $Defines CMAKE_Swift_COMPILER $SWIFTC
421-
422-
$TargetInfo = & $SWIFTC -target $Triple -print-target-info
423-
$TargetInfo = $TargetInfo | ConvertFrom-Json
424-
$TargetInfo = $TargetInfo.target.moduleTriple
425-
Add-KeyValueIfNew $Defines CMAKE_Swift_COMPILER_TARGET $TargetInfo
417+
Add-KeyValueIfNew $Defines CMAKE_Swift_COMPILER_TARGET $Triple
426418
427419
# TODO(compnerd) remove this once we have the early swift-driver
428420
Add-KeyValueIfNew $Defines CMAKE_Swift_COMPILER_USE_OLD_DRIVER "YES"

.github/workflows/swift-toolchain.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1614,8 +1614,8 @@ jobs:
16141614
'ZLIB_ROOT' = "${{ github.workspace }}/BuildRoot/Library/zlib-${{ inputs.zlib_version }}/usr";
16151615
'ZLIB_LIBRARY' = "${{ github.workspace }}/BuildRoot/Library/zlib-${{ inputs.zlib_version }}/usr/lib/zlibstatic.lib";
16161616
'BROTLI_INCLUDE_DIR' = "${{ github.workspace }}/BuildRoot/Library/brotli-${{ inputs.brotli_version }}/usr/include";
1617-
'BROTLICOMMON_LIBRARY' = "${{ github.workspace }}/BuildRoot/Library/brotli-${{ inputs.brotli_version }}/usr/lib/brotlicommon.lib";
1618-
'BROTLIDEC_LIBRARY' = "${{ github.workspace }}/BuildRoot/Library/brotli-${{ inputs.brotli_version }}/usr/lib/brotlidec.lib";
1617+
'BROTLICOMMON_LIBRARY' = "${{ github.workspace }}/BuildRoot/Library/brotli-${{ inputs.brotli_version }}/usr/lib/$(if ("${{ matrix.os }}" -eq "Windows") { "brotlicommon.lib" } else { "libbrotlicommon.a" })";
1618+
'BROTLIDEC_LIBRARY' = "${{ github.workspace }}/BuildRoot/Library/brotli-${{ inputs.brotli_version }}/usr/lib/$(if ("${{ matrix.os }}" -eq "Windows") { "brotlidec.lib" } else { "libbrotlidec.a" })";
16191619
'CMAKE_C_FLAGS' = "${{ inputs.use_host_toolchain && '' || '-fuse-ld=lld' }}";
16201620
}
16211621
- name: Build curl

0 commit comments

Comments
 (0)